From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C56FF3858407 for ; Thu, 26 May 2022 15:38:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C56FF3858407 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-1R-FEumWPnylVNI6HZO33Q-1; Thu, 26 May 2022 11:38:55 -0400 X-MC-Unique: 1R-FEumWPnylVNI6HZO33Q-1 Received: by mail-wr1-f69.google.com with SMTP id f6-20020a5d5686000000b0020ffb1157f4so376068wrv.9 for ; Thu, 26 May 2022 08:38:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UPsop8eryhN5t21w40IwEU72auDdz1OhVHoYx2KV+bM=; b=vHEJhwnENrskk2JlPn6R7yE4esqZZBU64y3wER37iZw3m/L/VaButH5DKaSoiBDcan 6akDZX/J4Z3iSaXJ+h1mHg2oQFM5U32VbZYSDbM6MBDzrKBw9QUIFPzB+bnvVFcFoDEM oIeJglJ7kpegO8OCvpGt+b3GR6b/NSu0NgCt/1TDvQCuOJkrYSGfkiq9ZbEmjfJ8KTqF Cc96nA3emkbY/MxaDcGaJ7O4duyPAaT+WDaN8xWj+9a0eJhoFW0V1ddnOXCEBeHL6w0A PSDcJpA1VuTsW6wexwXJQ9y0NatHYcDdLCfRHgzmUmqhCuym+I9F3KQ/wsEbZAHSn3Jq /QrA== X-Gm-Message-State: AOAM533x6zGkpxR3oZbI87rF8GOzAKA7WIr4mz/8KB45KzyGqiHzYpvw wKaXCL6v+WtuaexOCu/uCINuPtKvhXp1XOomqTEZT6gurjxGRjPy0eY8ut2+AM3E9SdBEyZab4h 4g16XNFBRKqZakAm/AMNv5w== X-Received: by 2002:a05:600c:89a:b0:397:3e2c:f416 with SMTP id l26-20020a05600c089a00b003973e2cf416mr2948258wmp.160.1653579534010; Thu, 26 May 2022 08:38:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsl9jJ968/0VpRkqncNsNFHlvoapy3rO0Y4SiscCK4CUig5IQxggp4Kc0RJ6PVNkJ0s128Ew== X-Received: by 2002:a05:600c:89a:b0:397:3e2c:f416 with SMTP id l26-20020a05600c089a00b003973e2cf416mr2948244wmp.160.1653579533836; Thu, 26 May 2022 08:38:53 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id c25-20020a05600c0ad900b00397550b387bsm2490700wmr.23.2022.05.26.08.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 08:38:53 -0700 (PDT) From: Andrew Burgess To: Ilya Leoshkevich , Tom Tromey Cc: Ulrich Weigand , Andreas Arnez , Pedro Alves , gdb-patches@sourceware.org, Ilya Leoshkevich Subject: Re: [PATCH 2/5] gdb.perf/: Add binary_link_with_shlibs setting to GenPerfTest In-Reply-To: <20220525223711.845475-3-iii@linux.ibm.com> References: <20220525223711.845475-1-iii@linux.ibm.com> <20220525223711.845475-3-iii@linux.ibm.com> Date: Thu, 26 May 2022 16:38:52 +0100 Message-ID: <87y1yogv77.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 15:38:58 -0000 Ilya Leoshkevich writes: > Performance tests that dynamically load generated shared libraries do > not need to link with them. Provide an option to avoid this. > --- > gdb/testsuite/lib/gen-perf-test.exp | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/gdb/testsuite/lib/gen-perf-test.exp b/gdb/testsuite/lib/gen-perf-test.exp > index 0a5607c2c9a..f0bfdc9317d 100644 > --- a/gdb/testsuite/lib/gen-perf-test.exp > +++ b/gdb/testsuite/lib/gen-perf-test.exp > @@ -100,6 +100,9 @@ namespace eval GenPerfTest { > # The number of compunits in each objfile. > set DEFAULT_NR_COMPUNITS 1 > > + # Link the binary with the generated shared libraries by default > + set DEFAULT_BINARY_LINK_WITH_SHLIBS 1 I think this should be: # Should the binary be linked with the generated shared libraries? set DEFAULT_BINARY_LINK_WITH_SHLIBS true As this matches the style of the existing comment. Plus use 'true' rather than '1'. OK with those changes. Thanks, Andrew > + > # The number of public globals in each compunit. > set DEFAULT_NR_EXTERN_GLOBALS 1 > > @@ -254,6 +257,7 @@ namespace eval GenPerfTest { > set testcase(tail_shlib_headers) $GenPerfTest::DEFAULT_TAIL_SHLIB_HEADERS > set testcase(nr_gen_shlibs) $GenPerfTest::DEFAULT_NR_GEN_SHLIBS > set testcase(nr_compunits) $GenPerfTest::DEFAULT_NR_COMPUNITS > + set testcase(binary_link_with_shlibs) $GenPerfTest::DEFAULT_BINARY_LINK_WITH_SHLIBS > > set testcase(nr_extern_globals) $GenPerfTest::DEFAULT_NR_EXTERN_GLOBALS > set testcase(nr_static_globals) $GenPerfTest::DEFAULT_NR_STATIC_GLOBALS > @@ -281,7 +285,7 @@ namespace eval GenPerfTest { > binary_extra_sources binary_extra_headers > gen_shlib_extra_sources gen_shlib_extra_headers > tail_shlib_sources tail_shlib_headers > - nr_gen_shlibs nr_compunits > + nr_gen_shlibs nr_compunits binary_link_with_shlibs > nr_extern_globals nr_static_globals > nr_extern_functions nr_static_functions > class_specs > @@ -1298,14 +1302,16 @@ namespace eval GenPerfTest { > > proc _make_shlib_options { self_var static run_nr } { > upvar 1 $self_var self > - set nr_gen_shlibs [_get_param $self(nr_gen_shlibs) $run_nr] > set result "" > - for { set i 0 } { $i < $nr_gen_shlibs } { incr i } { > - lappend result "shlib=[_make_shlib_name self $static $run_nr $i]" > - } > - set tail_shlib_name [_make_tail_shlib_name self $static $run_nr] > - if { "$tail_shlib_name" != "" } { > - lappend result "shlib=$tail_shlib_name" > + if { [_get_param $self(binary_link_with_shlibs) $run_nr] } { > + set nr_gen_shlibs [_get_param $self(nr_gen_shlibs) $run_nr] > + for { set i 0 } { $i < $nr_gen_shlibs } { incr i } { > + lappend result "shlib=[_make_shlib_name self $static $run_nr $i]" > + } > + set tail_shlib_name [_make_tail_shlib_name self $static $run_nr] > + if { "$tail_shlib_name" != "" } { > + lappend result "shlib=$tail_shlib_name" > + } > } > return $result > } > -- > 2.35.3