public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Nikolaos Chatzikonstantinou <nchatz314@gmail.com>,
	Nikolaos Chatzikonstantinou via Gdb-patches
	<gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix inconsistent input/output of example
Date: Wed, 18 May 2022 16:30:50 +0100	[thread overview]
Message-ID: <87y1yyj1sl.fsf@redhat.com> (raw)
In-Reply-To: <CAAQmeke8ubf4FV5yZuP=J4oE+VuBZUEofLQfHbnKDPm2brTO2A@mail.gmail.com>

Nikolaos Chatzikonstantinou via Gdb-patches <gdb-patches@sourceware.org>
writes:

> I corrected an example in 10.10.3 of the info page.
> I am not certain of it; please double-check.
> See attached patch.
> From 032dca4a43aa61c89208c2ffd978ef1dd121898d Mon Sep 17 00:00:00 2001
> From: Nikolaos Chatzikonstantinou <nchatz314@gmail.com>
> Date: Wed, 18 May 2022 22:28:02 +0900
> Subject: [PATCH] Fix inconsistent input/output of example
> To: gdb-patches@sourceware.org
>
> The shown output corresponds to an 'info pretty-printer' without an
> object-regexp, however the input was a 'library2' regexp.
> ---
>  gdb/doc/gdb.texinfo | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 9df109ba330..7d2555455d0 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -12110,7 +12110,7 @@ library2.so:
>  (gdb) disable pretty-printer library2 bar
>  1 printer disabled
>  0 of 3 printers enabled
> -(gdb) info pretty-printer library2
> +(gdb) info pretty-printer

This change looks correct to me, however, the same mistake is repeated a
few lines earlier in the example, it would be good to fix them both at
the same time I think.

Thanks,
Andrew


  reply	other threads:[~2022-05-18 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 13:35 Nikolaos Chatzikonstantinou
2022-05-18 15:30 ` Andrew Burgess [this message]
2022-05-18 21:14   ` Nikolaos Chatzikonstantinou
2022-05-19 14:24     ` [PUSHED 0/3] " Andrew Burgess
2022-05-19 14:24       ` [PUSHED 1/3] gdb/doc: fix inconsistent info pretty-printer example Andrew Burgess
2022-05-19 14:24       ` [PUSHED 2/3] gdb/doc: make use of group/end group in 'info pretty-printers' example Andrew Burgess
2022-05-19 14:24       ` [PUSHED 3/3] gdb/doc: use @value{GDBP} in 'info pretty-printer' example Andrew Burgess
2022-05-19 15:54       ` [PUSHED 0/3] Re: [PATCH] Fix inconsistent input/output of example Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1yyj1sl.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nchatz314@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).