From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E77F5386481B for ; Mon, 21 Mar 2022 17:52:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E77F5386481B Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-glhAYY_ZP7SZ7Sw1aP62Ww-1; Mon, 21 Mar 2022 13:52:26 -0400 X-MC-Unique: glhAYY_ZP7SZ7Sw1aP62Ww-1 Received: by mail-wm1-f71.google.com with SMTP id c62-20020a1c3541000000b003815245c642so10573256wma.6 for ; Mon, 21 Mar 2022 10:52:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=dEt+Ua5QLLjpUVv0ZQt7+ZEzu9MlZ2VD47ttecB/WuA=; b=ct5teH4f5UnY4u2odGGd/Tv5nNfcBqjZY6OSggnHXmWph25qdqglPI7YRToomEDnwR 8IwgGLtlwzvJMEz1i9uHCtHl4NOZhlcPor0M7J2MtjJWIqc49oCanx2K+nsV4rr2o10r YoYMdQFN/TZRE9y3Nh4TLCSskiFOMlZ2O1SdZNu2kIplu7cA2vsTM2aIAiFoGQ9wKFXE 97Rqh5frC5HeHa3kaiQYlLYyt5iCGroElyY1mM64xQYjlgJhJkc7K6B/V2V1wn8DV4id rC5PC5LZ+ad51aDZBCic2FDCktmq77mi02R+fcrhSLyEFR5CK+Ztett53Y1tU0u4pj1r A7cw== X-Gm-Message-State: AOAM530fOA6EjXB1/FcnyxnMcwEuBJ2R+0W0J4i8apUsw2Hlb4eUwKNR wbAHCd5LiBIj0PuALiFOvCuAWf6G/2vWcKADytz8J3YKF4Q6GdyEy2VG2Sw0BNOIPZ6hQMntpbi gFqIaE82/KOv4543sN6NWLq3lcClcevOSMefoytYWpGG7xYO3kqeTMdxctaK98mD6Jvoetx0sqw == X-Received: by 2002:a5d:4d84:0:b0:203:de2a:8e91 with SMTP id b4-20020a5d4d84000000b00203de2a8e91mr19340390wru.85.1647885144996; Mon, 21 Mar 2022 10:52:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9roF1tljtkWmOeC4fHKVLi6YpglVRwkhYlGqgDP05DY2QUfkVu5EvcdCYwluj6KItjnA54w== X-Received: by 2002:a5d:4d84:0:b0:203:de2a:8e91 with SMTP id b4-20020a5d4d84000000b00203de2a8e91mr19340374wru.85.1647885144701; Mon, 21 Mar 2022 10:52:24 -0700 (PDT) Received: from localhost (host109-158-45-15.range109-158.btcentralplus.com. [109.158.45.15]) by smtp.gmail.com with ESMTPSA id g6-20020adfd1e6000000b00203f8effc22sm14596790wrd.63.2022.03.21.10.52.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 10:52:24 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv3 00/15] TUI changes, new winwidth command and resizing changes In-Reply-To: References: Date: Mon, 21 Mar 2022 17:52:22 +0000 Message-ID: <87y213ry5l.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 17:52:30 -0000 Ping! Thanks, Andrew Andrew Burgess writes: > Since v2: > > - Rebased onto current upstream/master, > > - Patch #5 - Rewritten to not use templates! > > - Patch #6 - Added a bug in bugzilla, and referenced this from the > commit message, > > - Patch #7 - Renamed the existing methods rather than adding 2 new > methods, > > - Patch #10 - Updated the comment Tom identified as being out of > date, > > - Patch #15 - Have updated a comment that I spotted was out of date. > > Thanks, > Andrew > > > --- > > Andrew Burgess (15): > gdb: move some commands into the tui namespace > gdb/tui: rename tui_layout_base::adjust_size to ::set_height > gdb/tui: rename tui_layout_split:set_weights_from_heights > gdb/testing/tui: add new functionality to tuiterm.exp > gdb/tui: add new 'tui window width' command and 'winwidth' alias > gdb/tui: add a tui debugging flag > gdb/tui: add left_boxed_p and right_boxed_p member functions > gdb/tui/testsuite: refactor new-layout.exp test > gdb/tui: avoid fp exception when applying layouts > gdb/tui: fairer distribution of excess space during apply > gdb/tui: allow cmd window to change size in tui_layout_split::apply > gdb/tui: support placing the cmd window into a horizontal layout > gdb/testsuite: some additional tests in gdb.tui/scroll.exp > gdb/tui: relax restrictions on window max height and width > gdb/tui: fair split of delta after a resize > > gdb/NEWS | 25 ++ > gdb/doc/gdb.texinfo | 51 +++- > gdb/testsuite/gdb.tui/basic.exp | 4 +- > gdb/testsuite/gdb.tui/empty.exp | 14 +- > gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- > gdb/testsuite/gdb.tui/regs.exp | 4 +- > gdb/testsuite/gdb.tui/scroll.exp | 4 + > gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ > gdb/testsuite/gdb.tui/winwidth.exp | 63 +++++ > gdb/testsuite/lib/tuiterm.exp | 82 +++++- > gdb/tui/tui-command.c | 6 - > gdb/tui/tui-command.h | 2 - > gdb/tui/tui-layout.c | 406 ++++++++++++++++++++++----- > gdb/tui/tui-layout.h | 135 +++++++-- > gdb/tui/tui-win.c | 118 ++++++-- > gdb/tui/tui.c | 26 ++ > gdb/tui/tui.h | 14 + > 17 files changed, 971 insertions(+), 160 deletions(-) > create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp > > -- > 2.25.4