From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Aaron Merey <amerey@redhat.com>
Subject: Re: [PATCH v3] gdb: Improve debuginfod progress updates
Date: Fri, 18 Mar 2022 13:23:03 -0600 [thread overview]
Message-ID: <87y217gj54.fsf@tromey.com> (raw)
In-Reply-To: <CAJDtP-TfvGtKh4dfBWU2OiKYqsNKTEHt=UOTb5F5MkvgrJE+Sg@mail.gmail.com> (Aaron Merey via Gdb-patches's message of "Tue, 8 Mar 2022 20:26:43 -0500")
>> Instead of this, which seems like it can hide useful info from the user,
>> what do you think about a "cylon"-style display:
>>
>> Downloading mumble.so:
>> [ # ]
>>
>> ... where the '#' moves back and forth inside the [].
Aaron> I'd like to restrict the update messages to a single line so that an
Aaron> entire message can be overwritten with \r. Then when many downloads
Aaron> occur we avoid filling the terminal with "Downloading XY MB separate
Aaron> debuginfo for libxyz" messages.
Could you show what your proposed output looks like?
I mean, after everything is downloaded?
To me it seems like having a "Downloading..." message per .so is no big deal.
gdb is often chatty.
>> Technically MI does have a progress notification approach, see
>> mi_load_progress. I don't know if anything MI consumer actually uses
>> this, though, and so I'm not sure if it makes sense to try to wire this
>> up to debuginfo downloads.
Aaron> These MI implementations are the easiest way to see progress updates when
Aaron> using gdb+debuginfod with IDEs, for instance. Otherwise I think each IDE
Aaron> would have to learn how to parse and display the mi_load_progress output,
Aaron> preferably in a way that's consistent with the CLI progress messages.
I am not sure we're talking about the same thing... MI defines a
progress indication message, but your patch isn't using that. So I
wonder if any MI notification is needed at all.
Tom
next prev parent reply other threads:[~2022-03-18 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 0:58 [PATCH v2] gdb/debuginfod: Rework " Aaron Merey
2022-02-09 2:25 ` [PATCH v3] gdb: Improve debuginfod " Aaron Merey
2022-02-14 0:56 ` Patrick Monnerat
2022-02-16 2:09 ` Aaron Merey
2022-02-16 10:38 ` Patrick Monnerat
2022-02-17 16:06 ` Aaron Merey
2022-03-04 18:15 ` Tom Tromey
2022-03-09 1:26 ` Aaron Merey
2022-03-18 19:23 ` Tom Tromey [this message]
2022-03-22 0:27 ` Aaron Merey
2022-04-07 14:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y217gj54.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).