From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 24F193857C7E for ; Wed, 9 Mar 2022 11:48:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24F193857C7E Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-400-OEd8LNZoOaCOJZdkpQSsVg-1; Wed, 09 Mar 2022 06:48:10 -0500 X-MC-Unique: OEd8LNZoOaCOJZdkpQSsVg-1 Received: by mail-wm1-f70.google.com with SMTP id 10-20020a1c020a000000b0037fae68fcc2so2479962wmc.8 for ; Wed, 09 Mar 2022 03:48:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UCPC2r1I2+vLjn8GjCeHRR8/D0jAjhWokm3ycSFdIhk=; b=m4DHwKtQv62Gpjrig3n/hN9FtUxjfHr9V4liXxr6IF/6BVGTYQdXGmSJDQltY0I1Cx K3e8PpkdtFab/KINccu6fDta4Mq5vcwHxSlhhTr10e821d6zyxOeetc3sSL8RI1J3n/Z sHG7C8CJoEFD4X58iu2vHyAztyZavjvQFIf7AhaDJ4nD/jWbTZq1a3sfbHlWNOpWXaLy 51l9KG2Kdt3iY2PBXHTKWYT0g+eNnL721PFOQEQopvG2j4JBAMC0HRyxz8EOUFTU1sDD 2omhg4tuJM1/6l1VKTFmHSRzEkcry9E27MPOvNKgOcLUt1pZcmNELE1bOZK/lmxzkFwA 5COw== X-Gm-Message-State: AOAM531eLu+G+r9hAbmNcEdRZE7rG4MfKSEbn6ucgLuzN/jug8cVpYMu jZSS3Aw180zYwaIwJK7Y39QFVgcrDj5DMCikerXt361Oeei4d5M4fVDEaE66dAFq31hKOdLCK2G QWgPIYm4aagWo3nmyYiECXw== X-Received: by 2002:a05:6000:1868:b0:203:732f:d657 with SMTP id d8-20020a056000186800b00203732fd657mr3972977wri.664.1646826489153; Wed, 09 Mar 2022 03:48:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrk9nPTCcfF4dxPuvBZqd57htVWB37dMMrPLTk87uCE3csHe3SPdp9fnXoohB8hZq2RZlQgg== X-Received: by 2002:a05:6000:1868:b0:203:732f:d657 with SMTP id d8-20020a056000186800b00203732fd657mr3972964wri.664.1646826488945; Wed, 09 Mar 2022 03:48:08 -0800 (PST) Received: from localhost (host86-134-151-205.range86-134.btcentralplus.com. [86.134.151.205]) by smtp.gmail.com with ESMTPSA id b15-20020adfc74f000000b001e888b871a0sm1503827wrh.87.2022.03.09.03.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:48:08 -0800 (PST) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 06/15] gdb/tui: add a tui debugging flag In-Reply-To: <83ee3cfxln.fsf@gnu.org> References: <83ee3cfxln.fsf@gnu.org> Date: Wed, 09 Mar 2022 11:48:07 +0000 Message-ID: <87y21juz2g.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 11:48:15 -0000 Eli Zaretskii via Gdb-patches writes: >> Date: Mon, 7 Mar 2022 22:13:38 +0000 >> From: Andrew Burgess via Gdb-patches >> Cc: Andrew Burgess >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 1275d967a2d..eb18ac47804 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -133,6 +133,10 @@ winwidth >> the width of a tui window to be adjusted when windows are laid out >> in horizontal mode. >> >> +set debug tui on|off >> +show debug tui >> + Control the display of debug output about GDB's tui. >> + >> * Changed commands >> >> maint packet >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index 6081aa85af4..60173e07747 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -29205,6 +29205,17 @@ >> source text at the next tab stop; the compact display uses only as >> much space as is needed for the line numbers in the current file, and >> only a single space to separate the line numbers from the source. >> + >> +@kindex set debug tui >> +@item set debug tui @r{[}on|off@r{]} >> +Turn on or off display of @value{GDBN} internal debug messages relating >> +to the TUI. >> + >> +@kindex show debug tui >> +@item show debug tui >> +Show the current status of displaying @value{GDBN} internal debug >> +messages relating to the TUI. >> + > > The documentation parts are OK, but I wonder whether we should mention > the caveats you described, at least in NEWS. I'm aware that we don't > usually describe known bugs, but since you say this could cause > crashes, perhaps it justifies an exception? I don't know if that's really a route we want to start going down. Why would this bug deserve a NEWS entry over any other bug? Additionally, the 'set debug ...' flags are really only used for maintenance (I really with they were 'maint set debug ...', but they are what they are). My motivation for adding this text to the commit message is simply, that if a bug _was_ reported in this area, and a GDB maintainer tries to debug it, and they track it back to this commit ... then the commit message acknowledges that there is an issue here. Anyway, below is a patch that adds a NEWS entry for this bug. Let me know your thoughts. thanks, Andrew --- diff --git a/gdb/NEWS b/gdb/NEWS index 4d282cb37dd..166b7f57353 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -9,6 +9,11 @@ Python 2. From GDB 13, it will only be possible to build GDB itself with Python 3 support. +* Bug PR gdb/28948 exists, this can cause GDB to crash when logging + redirection is enabled, and the TUI interface is enabled and + disabled. See the following link for more details: + https://sourceware.org/bugzilla/show_bug.cgi?id=28948 + * Improved C++ template support GDB now treats functions/types involving C++ templates like it does function