From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id F3E053858D39 for ; Fri, 4 Mar 2022 16:37:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3E053858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 578C3100424F2 for ; Fri, 4 Mar 2022 16:37:50 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QAw9nmggUkku4QAwAn4Xlj; Fri, 04 Mar 2022 16:37:50 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SP+H6MjH c=1 sm=1 tr=0 ts=6222405e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=FLxKeKhPZkDjhqhUmw4A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9G/qeVov3pbAfnGR/Hcy/nLkgpNLt06WreS0DcwwvGE=; b=P9xglPPmdjrhHXeyGVmrJIhtDb fjZyPSbRVmefWlONw3+hYFB/RCoRocgMv9ZtqtpVaGsNBMz3KQdyXfx0cIG5crEwDvtgY/RxVHzYz 8eKrgNKS4X41un/bPS4YWasA1; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37914 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQAw9-002FCO-6l; Fri, 04 Mar 2022 09:37:49 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv2 07/15] gdb/tui: add left_boxed_p and right_boxed_p member functions References: X-Attribution: Tom Date: Fri, 04 Mar 2022 09:37:48 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Sun, 6 Feb 2022 14:12:45 +0000") Message-ID: <87y21psmg3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nQAw9-002FCO-6l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37914 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 16:37:52 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> I did consider just adding a comment about this to the above code, but Andrew> this still doesn't feel great. So, in this commit, I've just filled Andrew> in the API to add right_boxed_p and left_boxed_p, and now I call these Andrew> instead of bottom_boxed_p and top_boxed_p if appropriate. Andrew> Maybe it's just pointless noise.... Andrew> ... I'd rather the main apply function not have to have special Andrew> knowledge about the implementation of these things coded into it. It seems fine but I wonder if just renaming these methods would yield the same effective result without duplicating code. Tom