From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F2F793858D1E for ; Tue, 8 Feb 2022 09:23:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2F793858D1E Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-IeBdrrOKNRKzNEZXbTS9Jw-1; Tue, 08 Feb 2022 04:23:38 -0500 X-MC-Unique: IeBdrrOKNRKzNEZXbTS9Jw-1 Received: by mail-wr1-f71.google.com with SMTP id d13-20020adfa34d000000b001e33a1c56f3so506708wrb.20 for ; Tue, 08 Feb 2022 01:23:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=/WL56snp0MkdB9YHMH7P2gCWqFXCUBcHQ2I+ISxOELw=; b=IA2RkplffBLgsOVLth5xwXMRFRutAPegFnglUXoPI4eTUg+Aa3SPvOOfVVaMr5POn4 NaWgGkdc76xpEbubjhl9iYtaT+P0X/OYImtwNI5dIRh7ODjuOYLKRC8KGnmZXle0S2VD lvjUe0yqOQk3vg6Dio5zonQUEsupgztOTzzTf3E1foUQA/hLp6tUiydXDtqL1sozTLWw vcZfNOonhN7jAHllBU/Zpl/lddhGu4KKawle23Op6tSJ4GtXMW2jSyQeylFx+lAi9LS8 oEQCrJBPKXUI3M58bRH8Baghfu9HmpZzWTFg0K+11y/P4AD4xZ61ZAAezcHYBA3qsCQj zWfw== X-Gm-Message-State: AOAM53271C14cbsXAZKTUe9nHfCDxQqZ7uzNunsfXpRHXIJuNGUM3cwB +BeuLyvMwzLoBiH/ckuWlKRVLBnlr+qIiM0z5GRqLroou0eGkAgkZB3TQzLtERsk8jr+J2aJhoO TDCC6A9/kh3na1sHJqrcE0Q== X-Received: by 2002:adf:e8cd:: with SMTP id k13mr1820232wrn.270.1644312216948; Tue, 08 Feb 2022 01:23:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTjldEc/kAXeReuRgksBlwhkZpmiUrWbuq0YTCXMzpbq4m+UiGQrPPa+H4cAJBTdjmXOXlvQ== X-Received: by 2002:adf:e8cd:: with SMTP id k13mr1820223wrn.270.1644312216771; Tue, 08 Feb 2022 01:23:36 -0800 (PST) Received: from localhost (host86-134-151-224.range86-134.btcentralplus.com. [86.134.151.224]) by smtp.gmail.com with ESMTPSA id r6sm703884wrn.74.2022.02.08.01.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 01:23:36 -0800 (PST) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: remove tailing newlines from index_cache_debug calls In-Reply-To: <41ecbc94-012e-e765-e37f-3fd923276218@polymtl.ca> References: <20220207204547.3364272-1-aburgess@redhat.com> <41ecbc94-012e-e765-e37f-3fd923276218@polymtl.ca> Date: Tue, 08 Feb 2022 09:23:35 +0000 Message-ID: <87y22l90fc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 09:23:41 -0000 Simon Marchi via Gdb-patches writes: > On 2022-02-07 15:45, Andrew Burgess via Gdb-patches wrote: >> I noticed that most of the calls to index_cache_debug include a >> trailing newline. As the new debug mechanism already adds a newline, >> that means all of these debug calls result in a blank line being >> printed, which I think is a mistake. >> >> Remove all the trailing newlines. >> >> I also reformatted one of the index_cache_debug where a string will >> now fit onto a single line. >> >> Unless 'set debug index-cache on' is used, there should be no visible >> change in output after this commit. > > Thanks for doing this, it's surely an oversight on my part. I think it's an obvious change. Thanks, pushed. Andrew