Re: [PATCH v7] gdb: Add new 'print nibbles' feature

[Tom Tromey <tom@tromey.com>]

>>>>> ">" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:

>> This new feature displays binary values by group, with four
>> bits per group.

>> The motivation behind this work is to enhance the readability
>> of binary values.

Thank you for the patch.

>> +@item -nibbles [@code{on}|@code{off}]
>> +Set whether to print binary values in groups of four bits, known
>> +as ``nibbles''.  @xref{set print nibbles}.

I think if new print flags are added, we generally also add them to the
Python layer, see valpy_format_string.

>> +/* Return the digit separator for the current debugging language. */
>> +
>> +static char
>> +get_digit_separator ()
>> +{
>> +  if (current_language != nullptr)
>> +    {
>> +      switch (current_language->la_language)
>> +	{
>> +	case language_cplus:
>> +	  return '\'';
>> +	case language_rust:
>> +	  return '_';
>> +	default:
>> +	  return ' ';
>> +	}
>> +    }
>> +  else
>> +    return ' ';

It's better to add this kind of thing to the language object itself, or
to generic_val_print_decorations.  I'd say probably the latter,
depending on whether that's difficult.

>> +		  if ((0xf0 & (mask >> i) && (*p & 0xf0)) ||
>> +		      (0x0f & (mask >> i) && (*p & 0x0f)))

In gdb operators are put at the start of the continuing line.
Also this reads very weirdly to me.  It could probably benefit from some
explict "!= 0" somewhere.

thanks,
Tom