Re: [PATCHv5 0/4] Python API for target connections, and packet sending

[Andrew Burgess <aburgess@redhat.com>]

Ping!

I think I addressed all the issues from the last round of feedback.

Thanks,
Andrew

Andrew Burgess <andrew.burgess@embecosm.com> writes:

> Since v4:
>
>   - Updated to latest upstream/master.
>
>   - Replaced string comparison on process_stratum_target::shortname()
>     with a new helper function is_remote_target declared in remote.h,
>     and defined in remote.c.
>
>   - Fixed a bug in py-send-packet.exp (patch #4) when running the test
>     using Python 3.
>
> Since v3:
>
>   - Addressed all review comments.
>
>   - The RemoteTargetConnection.send_packet method now returns a bytes
>     object for Py3, and a bytesarray object for Py2.  This change is
>     in patch #3.
>
>   - New patch #4 fixes GDB so that we can correctly return packets
>     containing null bytes, this fixes both 'maint packet' and the
>     Python API.
>
> Since v2:
>
>   - Added a gdb.RemoteTargetConnection sub-class, which is used for
>     'remote' and 'extended-remote' connections.  The previous
>     'send_remote_packet' has become 'send_packet' on this new
>     sub-class.
>
>   - Tests and documentation have been updated to reflect the above
>     change.
>
>   - In the first patch, connpy_repr has been modified in order to
>     prepare it for the sub-class that will appear in the later
>     patch.
>
> Since v1:
>
>   - Rebased onto current upstream master and resolved the merge
>     conflicts.
>
>   - Addressed the documentation feedback from Eli.  I'm not 100% sure
>     that I have correctly addressed the concerns about patch #3, so
>     this is probably worth rechecking.
>
>
> ---
>
> Andrew Burgess (4):
>   gdb/python: introduce gdb.TargetConnection object type
>   gdb: make packet_command function available outside remote.c
>   gdb/python: add gdb.RemoteTargetConnection.send_packet
>   gdb: handle binary data in 'maint packet' and
>     RemoteTargetConnection.send_packet
>
>  gdb/Makefile.in                               |   1 +
>  gdb/NEWS                                      |  21 +
>  gdb/doc/gdb.texinfo                           |   1 +
>  gdb/doc/python.texi                           | 127 ++++-
>  gdb/observable.c                              |   1 +
>  gdb/observable.h                              |   3 +
>  gdb/python/py-all-events.def                  |   1 +
>  gdb/python/py-connection.c                    | 536 ++++++++++++++++++
>  gdb/python/py-event-types.def                 |   5 +
>  gdb/python/py-inferior.c                      |  16 +
>  gdb/python/python-internal.h                  |   6 +
>  gdb/python/python.c                           |   5 +
>  gdb/remote.c                                  | 113 ++--
>  gdb/remote.h                                  |  42 ++
>  gdb/target-connection.c                       |   4 +
>  .../gdb.multi/multi-target-info-inferiors.exp |  38 ++
>  .../gdb.multi/multi-target-info-inferiors.py  |  63 ++
>  gdb/testsuite/gdb.python/py-connection.c      |  22 +
>  gdb/testsuite/gdb.python/py-connection.exp    |  75 +++
>  gdb/testsuite/gdb.python/py-inferior.exp      |  20 +-
>  gdb/testsuite/gdb.python/py-send-packet.c     |  22 +
>  gdb/testsuite/gdb.python/py-send-packet.exp   |  89 +++
>  gdb/testsuite/gdb.python/py-send-packet.py    | 109 ++++
>  23 files changed, 1281 insertions(+), 39 deletions(-)
>  create mode 100644 gdb/python/py-connection.c
>  create mode 100644 gdb/testsuite/gdb.multi/multi-target-info-inferiors.py
>  create mode 100644 gdb/testsuite/gdb.python/py-connection.c
>  create mode 100644 gdb/testsuite/gdb.python/py-connection.exp
>  create mode 100644 gdb/testsuite/gdb.python/py-send-packet.c
>  create mode 100644 gdb/testsuite/gdb.python/py-send-packet.exp
>  create mode 100644 gdb/testsuite/gdb.python/py-send-packet.py
>
> -- 
> 2.25.4