From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.94]) by sourceware.org (Postfix) with ESMTPS id 69E933857C66 for ; Thu, 4 Nov 2021 18:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69E933857C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 79EF111F1EA for ; Thu, 4 Nov 2021 13:00:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ih2Um4LeOIWzGih2UmAr3Y; Thu, 04 Nov 2021 13:00:38 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K1CDj2kegfbosOwtY7P3Aj2oC8jiDNvxUwcmgEd1TNw=; b=UcjQM9DP1BksAVu9jLZPZF7M5p cfHBJEjwfqiSbdmQoV53ciosDqM4WO8TvyJyWC77eX6dTRJVFgMOqMfkezLJ+eLMIPB1h0RBi1Fko uM+IOw9NFEyUiXeSXNky5rOXf; Received: from 75-166-134-234.hlrn.qwest.net ([75.166.134.234]:54126 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mih2T-0036QQ-RH; Thu, 04 Nov 2021 12:00:37 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Tom Tromey , Lancelot SIX Subject: Re: [PATCH 13/30] Statically examine abbrev properties References: <20210826021937.1490292-1-tom@tromey.com> <20210826021937.1490292-14-tom@tromey.com> <20210906223123.tyvpxqevmtlpurcg@ubuntu.lan> X-Attribution: Tom Date: Thu, 04 Nov 2021 12:00:36 -0600 In-Reply-To: <20210906223123.tyvpxqevmtlpurcg@ubuntu.lan> (Lancelot SIX via Gdb-patches's message of "Mon, 6 Sep 2021 22:31:23 +0000") Message-ID: <87y263kdh7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.234 X-Source-L: No X-Exim-ID: 1mih2T-0036QQ-RH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-234.hlrn.qwest.net (murgatroyd) [75.166.134.234]:54126 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 18:00:42 -0000 >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: >> + default: >> + is_csize = false; >> + break; >> + case DW_FORM_ref_addr: >> + case DW_FORM_GNU_ref_alt: >> + case DW_FORM_addr: >> + is_csize = false; >> + break; >> + } Lancelot> Were the three last case meant to be replaced by the 'default' Lancelot> entry but forgotten at some point? It looks like they could Lancelot> be removed. Thanks for noticing this. An earlier revision of this code did a bit more work in this switch, and when I removed that, I forgot to combine these cases. I've fixed this now. Tom