Re: [PATCH] Resolve dynamic types before computing pointer size

[Tom Tromey <tom@tromey.com>]

Keith> Unfortunately, my patch to find_size_for_pointer_math interferes with your recently committed
Keith> patch ["Fix bug in dynamic type resolution"], which you "snuck" [:-)] in before I could finish
Keith> rebasing and retesting my patch.

Tom> Sorry about that.

I debugged this today and came up with the appended.

The ada-lang.c hunk is the important bit.  I don't see a reason to call
value_addr here, and this call results in a value that has no address.

It seems wrong to have a not_lval object with a 0 address that can then
be treated as a pointer.  Though in this case, the value has
contents... so I wonder if that's something your patch needs to account
for.

The other hunk just changes the failure from 0x4 to 0x0, which seems
more correct in this case.  Though I wonder if this should really go in,
since it seems like it could do the wrong thing on platforms where 0 is
a valid address.

Tom

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 8b9e94e25d8..b9c693e277c 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -10685,9 +10685,6 @@ ada_funcall_operation::evaluate (struct type *expect_type,
 	 well.  */
       callee = ada_to_fixed_value (coerce_ref (callee));
     }
-  else if (value_type (callee)->code () == TYPE_CODE_ARRAY
-	   && VALUE_LVAL (callee) == lval_memory)
-    callee = value_addr (callee);
 
   struct type *type = ada_check_typedef (value_type (callee));
 
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index b39d2b72348..b162e8fe20c 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -2619,7 +2619,9 @@ resolve_dynamic_struct (struct type *type,
       pinfo.valaddr = addr_stack->valaddr;
       if (!pinfo.valaddr.empty ())
 	pinfo.valaddr = pinfo.valaddr.slice (offset);
-      pinfo.addr = addr_stack->addr + offset;
+      pinfo.addr = addr_stack->addr;
+      if (pinfo.addr != 0)
+	pinfo.addr += offset;
       pinfo.next = addr_stack;
 
       resolved_type->field (i).set_type