public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Zoran Zaric <zoran.zaric@amd.com>
Cc: Tom Tromey <tromey@adacore.com>,
	 Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 15/17] Make DWARF evaluator return a single struct value
Date: Fri, 13 Aug 2021 10:59:37 -0600	[thread overview]
Message-ID: <87y295b7ra.fsf@tromey.com> (raw)
In-Reply-To: <e22fbb31-fa8b-0218-8c8f-5d0ef97b293d@amd.com> (Zoran Zaric's message of "Fri, 13 Aug 2021 10:57:29 +0100")

Zoran> Thanks for reporting this, I will look into it ASAP.

Take a look at the patches I sent.

Zoran> I am curious about how can the frame arch and the arch given for the
Zoran> evaluation of the expression while focused on the same frame be
Zoran> different.

The arch that's currently used here comes from:

  gdbarch *arch = this->m_per_objfile->objfile->arch ();

The objfile's arch is just whatever gdb guesses from the executable.
I think it may be fairly non-specific, especially if the architecture
has a lot of variants.  In a case like this, the arch returned by
gdbserver, say, may include more details -- the specific registers
available, etc.

Tom

  reply	other threads:[~2021-08-13 16:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 15:46 [PATCH v3 00/17] DWARF expression evaluator design cleanup Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 01/17] Replace the symbol needs evaluator with a parser Zoran Zaric
2021-06-07 21:48   ` Simon Marchi
2021-06-11 17:22     ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 02/17] Cleanup of the dwarf_expr_context constructor Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 03/17] Move frame context info to dwarf_expr_context Zoran Zaric
2021-06-09  0:45   ` Simon Marchi
2021-06-11 17:16     ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 04/17] Remove get_frame_cfa from dwarf_expr_context Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 05/17] Move compilation unit info to dwarf_expr_context Zoran Zaric
2021-06-09  0:50   ` Simon Marchi
2021-06-11 17:19     ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 06/17] Move dwarf_call " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 07/17] Move get_object_address " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 08/17] Move read_mem " Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 09/17] Move push_dwarf_reg_entry_value to expr.c Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 10/17] Inline get_reg_value method of dwarf_expr_context Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 11/17] Remove empty frame and full evaluators Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 12/17] Merge evaluate_for_locexpr_baton evaluator Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 13/17] Move piece_closure and its support to expr.c Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 14/17] Make value_copy also copy the stack data member Zoran Zaric
2021-05-28 15:46 ` [PATCH v3 15/17] Make DWARF evaluator return a single struct value Zoran Zaric
2021-08-11 17:00   ` Tom Tromey
2021-08-12 18:03     ` Tom Tromey
2021-08-13  9:57       ` Zoran Zaric
2021-08-13 16:59         ` Tom Tromey [this message]
2021-08-13 17:57           ` Zoran Zaric
2021-08-16 15:37             ` Tom Tromey
2021-08-16 16:05               ` Zoran Zaric
2021-08-16 17:32                 ` Tom Tromey
2021-05-28 15:46 ` [PATCH v3 16/17] Simplify dwarf_expr_context class interface Zoran Zaric
2021-06-09  1:01   ` Simon Marchi
2021-06-11 17:20     ` Zaric, Zoran (Zare)
2021-05-28 15:46 ` [PATCH v3 17/17] Add as_lval argument to expression evaluator Zoran Zaric
2021-06-09  1:04 ` [PATCH v3 00/17] DWARF expression evaluator design cleanup Simon Marchi
2021-08-05 16:38   ` Zaric, Zoran (Zare)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y295b7ra.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=zoran.zaric@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).