From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (unknown [192.185.45.2]) by sourceware.org (Postfix) with ESMTPS id 48564385BF81 for ; Sat, 18 Apr 2020 14:41:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48564385BF81 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id CB31F400D185B for ; Sat, 18 Apr 2020 09:41:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id PofCjVcGkXVkQPofCjhDFx; Sat, 18 Apr 2020 09:41:46 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b+zrUd9hSmd03b6Pp5iptRB5yuzsJBmcQlTyT3sQcCU=; b=M2yY5KPEDhco+yFkIegM7bOvkS Xp2hqNBrUyrxtupZkeFLb8/YVPszUmrGQaXmaxLBXGNyLMFCfj6oMtkQT1tS/okWBLDEcehYQXMaS Ahhav/4eo6XHu14blZjloy1B/; Received: from 174-16-123-2.hlrn.qwest.net ([174.16.123.2]:42168 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jPofC-003yQt-Gr; Sat, 18 Apr 2020 08:41:46 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Change get_objfile_arch to a method on objfile References: <20200404221652.14598-1-tom@tromey.com> X-Attribution: Tom Date: Sat, 18 Apr 2020 08:41:45 -0600 In-Reply-To: <20200404221652.14598-1-tom@tromey.com> (Tom Tromey's message of "Sat, 4 Apr 2020 16:16:52 -0600") Message-ID: <87y2qsj1p2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.123.2 X-Source-L: No X-Exim-ID: 1jPofC-003yQt-Gr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-123-2.hlrn.qwest.net (bapiya) [174.16.123.2]:42168 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2020 14:41:49 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> This changes get_objfile_arch to be a new inline method, Tom> objfile::arch. Tom> To my surprise, this function came up while profiling DWARF psymbol Tom> reading. Making this change improved performance from 1.986 seconds Tom> to 1.869 seconds. Both measurements were done by taking the mean of Tom> 10 runs on a fixed copy of the gdb executable. I'm checking this in now. Tom