From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 78152385BF83 for ; Mon, 6 Apr 2020 18:58:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 78152385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 59921116D60; Mon, 6 Apr 2020 14:58:32 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id COKKZtOHGE2d; Mon, 6 Apr 2020 14:58:32 -0400 (EDT) Received: from murgatroyd (174-16-110-145.hlrn.qwest.net [174.16.110.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 0A5D1116D32; Mon, 6 Apr 2020 14:58:31 -0400 (EDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Select variant field when printing variant (no-tn-check) References: <20200330185547.18256-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 06 Apr 2020 12:58:31 -0600 In-Reply-To: <20200330185547.18256-1-tromey@adacore.com> (Tom Tromey's message of "Mon, 30 Mar 2020 12:55:47 -0600") Message-ID: <87y2r8cug8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 18:58:33 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> When I updated the Ada variant-printing code to be value-based, I Tom> neglected a couple of issues. First, print_variant_part must first Tom> extract the variant field before finding the active component; second, Tom> print_field_values should pass in the field value as the outer value Tom> when recursing. Tom> This patch fixes both of these issues. Tom> gdb/ChangeLog Tom> 2020-03-30 Tom Tromey Tom> * ada-valprint.c (print_variant_part): Extract the variant field. Tom> (print_field_values): Use the field as the outer value when Tom> recursing. I'm checking this in now. Tom