public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle unreachable network in server-connect.exp
Date: Tue, 17 Sep 2019 18:01:00 -0000	[thread overview]
Message-ID: <87y2ymx0o2.fsf@tromey.com> (raw)
In-Reply-To: <20190914102344.GA5471@delia> (Tom de Vries's message of "Sat, 14	Sep 2019 12:23:47 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +	    set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
Tom> +	    if { $res == 0 } {
Tom>  		pass $test
Tom> -	    } else {
Tom> +	    } elseif { $res == 1 }  {
Tom>  		fail $test
Tom> +	    } else {
Tom> +		unsupported $test

Should this treatment be applied to the other callers of gdb_target_cmd?

I agree with Sergio that the patch is fine, but I wonder if a bigger
cleanup is warranted here.

thanks,
Tom

  parent reply	other threads:[~2019-09-17 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-14 10:23 Tom de Vries
2019-09-17 15:40 ` Sergio Durigan Junior
2019-09-17 18:01 ` Tom Tromey [this message]
2019-09-18 11:56   ` Tom de Vries
2019-09-18 21:27     ` Tom Tromey
2019-09-18 23:16       ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2ymx0o2.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).