From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69687 invoked by alias); 17 Sep 2019 18:01:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69674 invoked by uid 89); 17 Sep 2019 18:01:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:535, bigger X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2019 18:01:05 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 5DE2583957C for ; Tue, 17 Sep 2019 13:01:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id AHmgiWRfA4FKpAHmgiWmSQ; Tue, 17 Sep 2019 13:01:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1d2Rx9UNjaHdm3jnqrlctHGPgFB+lFscp3vmvDplYN4=; b=dPm6lF5na0jj7YsNfooG+xNn8Y p58CVseHCYG+tFe48+IQpsKJKnCrlYBrIuWq3BXLIfqsLP3rpuNCjdQbfS81xFzY24kES6OsDQgDQ McSaf1MgmPxNxygGDedgl8l6n; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:59644 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iAHmg-002oYG-3n; Tue, 17 Sep 2019 13:01:02 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Handle unreachable network in server-connect.exp References: <20190914102344.GA5471@delia> Date: Tue, 17 Sep 2019 18:01:00 -0000 In-Reply-To: <20190914102344.GA5471@delia> (Tom de Vries's message of "Sat, 14 Sep 2019 12:23:47 +0200") Message-ID: <87y2ymx0o2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00321.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> + set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport] Tom> + if { $res == 0 } { Tom> pass $test Tom> - } else { Tom> + } elseif { $res == 1 } { Tom> fail $test Tom> + } else { Tom> + unsupported $test Should this treatment be applied to the other callers of gdb_target_cmd? I agree with Sergio that the patch is fine, but I wonder if a bigger cleanup is warranted here. thanks, Tom