From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59563 invoked by alias); 25 Apr 2019 19:43:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59553 invoked by uid 89); 25 Apr 2019 19:43:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=roll X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.200.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 19:43:44 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 129B9400C75EA for ; Thu, 25 Apr 2019 14:02:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JkHXhzZsk2PzOJkHXhV2TR; Thu, 25 Apr 2019 14:43:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fd49q9ERMVK8PikNQsJroSGij82N37M9q748W+d+BYM=; b=ZZtzzyMgOoszvTZE7m25c3DXxX 7821WI7uqYtL+EfRIBHu82GVVwW2MON2UA4/szsBlc+67Z0nht2VryrAhLDUQCfcYSBCgZVGV3Uo+ upG1tunb/M6lHjrLHvalDGwnj; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:59162 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJkHX-001oQ5-6K; Thu, 25 Apr 2019 14:43:43 -0500 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [RFC 4/8] mi/python: C++ify python MI command handling code References: <20190418152337.6376-1-jan.vrany@fit.cvut.cz> <20190418152337.6376-5-jan.vrany@fit.cvut.cz> Date: Thu, 25 Apr 2019 19:43:00 -0000 In-Reply-To: <20190418152337.6376-5-jan.vrany@fit.cvut.cz> (Jan Vrany's message of "Thu, 18 Apr 2019 16:23:33 +0100") Message-ID: <87y33x7tw1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00561.txt.bz2 >>>>> "Jan" == Jan Vrany writes: Jan> Use gdbpy_ref<> instead of manually calling Py_DECREF(). Jan> Use gdb::unique_xmalloc_ptr<> instead of manually calling xfree(). I'm reading these in order so of course my comments are all invalidated by reading the next patch. I'd just roll this one into the previous one. Tom