From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67475 invoked by alias); 6 Mar 2019 19:11:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67465 invoked by uid 89); 6 Mar 2019 19:11:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.144) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 19:11:42 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B1B5E11479 for ; Wed, 6 Mar 2019 13:11:39 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1bx5hoqnWYTGM1bx5h4NS4; Wed, 06 Mar 2019 13:11:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gwTpmBR58Dy7HH5pQoo3XJW3Kn7IOL6FNu2i/PTUUTg=; b=GSjOCdhEAxDHlTyJl0dZBGQRJN TZMCLLZE0unV9cLB+u2gQNCChnznbAIQ78OiFEuYn8Yv+Ca/YdBEHUdUxPA5kjw78553wOc1ia8qL 8Z1YDlytpRysP3v2IPLhK1EUa; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:58882 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1bx5-0012o5-6T; Wed, 06 Mar 2019 13:11:39 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED 10/11] gdb/fortran: Add support for the ABS intrinsic function References: <739027546fc7a430867d9d6dd2bf6b8e34e04c94.1551895529.git.andrew.burgess@embecosm.com> Date: Wed, 06 Mar 2019 19:11:00 -0000 In-Reply-To: <739027546fc7a430867d9d6dd2bf6b8e34e04c94.1551895529.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 6 Mar 2019 18:15:03 +0000") Message-ID: <87y35rom1h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00113.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Adds support for the abs intrinsic function, this requires adding a Andrew> new pattern to the Fortran parser. Currently only float and integer Andrew> argument types are supported to ABS, complex is still not supported, Andrew> this can be added later if needed. Sorry for not looking at these earlier... Andrew> +/* Create and return a value object of TYPE containing the value D. The Andrew> + TYPE must be of TYPE_CODE_FLT, and must be large enough to hold D once Andrew> + it is converted to target format. */ Andrew> + Andrew> +static struct value * Andrew> +value_from_host_double (struct type *type, double d) Andrew> +{ Andrew> + struct value *value = allocate_value (type); Andrew> + gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT); Andrew> + target_float_from_host_double (value_contents_raw (value), Andrew> + value_type (value), d); Andrew> + return value; This seems reasonable to move to value.c. At least py-value.c could use it. I can do that if you also think it's worthwhile. Tom