From: Tom Tromey <tom@tromey.com>
To: Andreas Krebbel <krebbel@linux.ibm.com>
Cc: tom@tromey.com, gdb-patches@sourceware.org,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [Committed] Python doc build fixes
Date: Tue, 09 Oct 2018 20:01:00 -0000 [thread overview]
Message-ID: <87y3b6c2l5.fsf@tromey.com> (raw)
In-Reply-To: <1538985549-19863-1-git-send-email-krebbel@linux.ibm.com> (Andreas Krebbel's message of "Mon, 8 Oct 2018 09:59:09 +0200")
>>>>> "Andreas" == Andreas Krebbel <krebbel@linux.ibm.com> writes:
Andreas> From: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Andreas> I've just committed this patch to fix doc build for me.
Thank you. And, sorry about the breakage.
Andreas> 2018-10-08 Andreas Krebbel <krebbel@linux.ibm.com>
Andreas> * python.texi (Inferior.Architecture): Add "@end defun". Rename
Andreas> ref target to "Unwinding Frames in Python".
I think you didn't commit the ChangeLog change.
Andreas> -particular frame (@pxref{Frames in Python}).
Andreas> +particular frame (@pxref{Unwinding Frames in Python}).
This was intended to link to the general information about gdb.Frame,
not to the node about how to write an unwinder, which seems less
relevant in context.
However, I typo'd the "in" -- it should have been "In".
I'm checking in the appended to change this to what was originally
intended.
Tom
commit 163cffefafb1d427ab46603d98bbfc45e813c9a0
Author: Tom Tromey <tom@tromey.com>
Date: Tue Oct 9 13:57:10 2018 -0600
Make @pxref for Inferior.architecture point to gdb.Frame documentation
This fixes he @pxref in Inferior.architecture to point to the "Frames
In Python" node, as originally intended; somewhat reverting an earlier
build fix. The initial patch had typod the "In".
Tested by "make info".
gdb/doc/ChangeLog
2018-10-09 Tom Tromey <tom@tromey.com>
* python.texi (Inferiors In Python): Link to "Frames In Python",
not "Unwinding Frames in Python".
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index c67798399f..0cab170456 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-09 Tom Tromey <tom@tromey.com>
+
+ * python.texi (Inferiors In Python): Link to "Frames In Python",
+ not "Unwinding Frames in Python".
+
2018-10-09 Tom Tromey <tom@tromey.com>
* gdb.texinfo (Configure Options): Update --enable-ubsan
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index 2320be63dd..ff5fecea1b 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -2865,7 +2865,7 @@ Return the @code{gdb.Architecture} (@pxref{Architectures In Python})
for this inferior. This represents the architecture of the inferior
as a whole. Some platforms can have multiple architectures in a
single address space, so this may not match the architecture of a
-particular frame (@pxref{Unwinding Frames in Python}).
+particular frame (@pxref{Frames In Python}).
@end defun
@findex Inferior.read_memory
next prev parent reply other threads:[~2018-10-09 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 18:46 [PATCH 0/2] two more Python paper-cuts Tom Tromey
2018-09-15 18:46 ` [PATCH 1/2] Update symbol domain and location values for Python Tom Tromey
2018-09-15 19:58 ` Eli Zaretskii
2018-09-15 18:46 ` [PATCH 2/2] Add Inferior.architecture method Tom Tromey
2018-09-15 19:58 ` Eli Zaretskii
2018-10-08 7:59 ` [Committed] Python doc build fixes Andreas Krebbel
2018-10-09 20:01 ` Tom Tromey [this message]
2018-10-07 5:21 ` [PATCH 0/2] two more Python paper-cuts Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3b6c2l5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=krebbel@linux.ibm.com \
--cc=krebbel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).