public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	 Tom Tromey <tom@tromey.com>,
	 gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands
Date: Thu, 30 Aug 2018 02:19:00 -0000	[thread overview]
Message-ID: <87y3covbnv.fsf@tromey.com> (raw)
In-Reply-To: <20180828232948.GK32506@embecosm.com> (Andrew Burgess's message	of "Wed, 29 Aug 2018 00:29:49 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> In general I'm happy to rework this part of GDB, but ideally I'd like
Andrew> some feedback from a global maintainer that such a change, which might
Andrew> would break backward compatibility, would be acceptable...

My philosophy has generally been to avoid incompatibility when possible
and when there seems to be some likelihood that the behavior is actually
used.

So, for example, I felt ok changing the parsing of "bt" arguments,
because I felt the implementation was simply buggy and that nobody would
be using its weird corner cases.

On the other hand, back in the day I changed the parsing of
"disassemble" and heard complaints for quite some time.  I guess this
informed my view.

Sometimes this leads to bad results, like how users should nearly always
use "watch -location", but it isn't the default.


This is why I think the paren grouping idea is fine: the examples I can
think of all seem useless.


That said, upthread you mentioned the idea of passing a flag to "define"
to change how arguments are parsed.  I would be ok with this as well.
However I think that in this case it would be good to work out the
details beforehand, including looking through bugzilla to see if there
are other unmet needs.

Tom

  reply	other threads:[~2018-08-30  2:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 14:39 [PATCH 0/2] " Andrew Burgess
2018-08-15 14:39 ` [PATCH 1/2] gdb: Make testnames unique in gdb.base/commands.exp Andrew Burgess
2018-08-30 15:26   ` Tom Tromey
2018-08-15 14:39 ` [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands Andrew Burgess
2018-08-15 18:24   ` Eli Zaretskii
2018-08-25 19:32   ` Philippe Waroquiers
2018-08-25 20:53     ` Philippe Waroquiers
2018-08-25 22:43       ` Andrew Burgess
2018-08-28 15:54         ` Tom Tromey
2018-08-28 18:43           ` Andrew Burgess
2018-08-28 20:29             ` Philippe Waroquiers
2018-08-28 23:29               ` Andrew Burgess
2018-08-30  2:19                 ` Tom Tromey [this message]
2018-08-30 21:19                 ` Philippe Waroquiers
2018-08-31 20:59                   ` Tom Tromey
2018-09-01 11:10                     ` Philippe Waroquiers
2018-09-01 14:20                       ` Tom Tromey
2018-09-01 15:36                         ` Philippe Waroquiers
2018-08-30  2:26               ` Tom Tromey
2018-09-06 23:29   ` [PATCHv2] gdb: Rewrite argument handling for " Andrew Burgess
2018-09-07  6:31     ` Eli Zaretskii
2018-09-07 20:36     ` Tom Tromey
2018-09-07 22:47       ` Andrew Burgess
2018-09-08  6:27         ` Eli Zaretskii
2018-09-08  5:35     ` Philippe Waroquiers
2018-09-08 14:33       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3covbnv.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).