From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] default_type_align: Use type_length_units
Date: Thu, 14 Jun 2018 19:50:00 -0000 [thread overview]
Message-ID: <87y3fhcflw.fsf@tromey.com> (raw)
In-Reply-To: <b45b360851abb796892dca0743a18872@polymtl.ca> (Simon Marchi's message of "Thu, 14 Jun 2018 14:25:49 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> This use seems related to C++, and our compiler is C only, so I can't
Simon> test that. But it would make sense, I can include that change if you
Simon> prefer.
Yeah, I think it would be best to either change both or change neither
(and update the comment).
Tom
next prev parent reply other threads:[~2018-06-14 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 22:24 Simon Marchi
2018-06-14 16:59 ` Tom Tromey
2018-06-14 18:26 ` Simon Marchi
2018-06-14 19:50 ` Tom Tromey [this message]
2018-06-14 22:28 ` Simon Marchi
2018-06-15 16:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3fhcflw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).