From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69505 invoked by alias); 6 Apr 2018 21:20:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69496 invoked by uid 89); 6 Apr 2018 21:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.219) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Apr 2018 21:20:53 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 1DCC83F1454 for ; Fri, 6 Apr 2018 16:20:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4YmyfYuwXA3CS4Ymyfhxca; Fri, 06 Apr 2018 16:20:52 -0500 Received: from 75-166-37-45.hlrn.qwest.net ([75.166.37.45]:40484 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f4Ymx-003kkw-QG; Fri, 06 Apr 2018 16:20:51 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 00/12] (somewhat) clean up struct value ownership References: <20180405211507.6103-1-tom@tromey.com> <97bbc817-5825-9abb-54d4-df041a61700f@redhat.com> Date: Fri, 06 Apr 2018 21:20:00 -0000 In-Reply-To: <97bbc817-5825-9abb-54d4-df041a61700f@redhat.com> (Pedro Alves's message of "Fri, 6 Apr 2018 20:33:10 +0100") Message-ID: <87y3i0m3pp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f4Ymx-003kkw-QG X-Source-Sender: 75-166-37-45.hlrn.qwest.net (pokyo) [75.166.37.45]:40484 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00105.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> As I'm reading the series, I'm also wishing for making some of the Pedro> value-related free-functions methods of value instead Yeah. When I wrote my note I meant to mention a couple of other things, and then forgot to. Class-ifying value more completely was one of them. Another one would be to do a bigger transform from "struct value *" to "value_ref_ptr" (and "const value_ref_ptr &") everywhere, to try to reduce the number of inc/dec-ref calls to a bare minimum, maybe even zero. I'm not sure if I'll attempt those, since I have other maintenance cleanups in mind as well. Tom