From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74699 invoked by alias); 26 Feb 2018 16:16:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74222 invoked by uid 89); 26 Feb 2018 16:16:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 16:16:56 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 61D0214D39 for ; Mon, 26 Feb 2018 10:16:55 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qLSRetC1kmzEzqLSResUzt; Mon, 26 Feb 2018 10:16:55 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:39228 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eqLSR-002HYM-2m; Mon, 26 Feb 2018 10:16:55 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-5-tom@tromey.com> <20180226065620.z6dzyzrlr72kylnn@adacore.com> Date: Mon, 26 Feb 2018 16:16:00 -0000 In-Reply-To: <20180226065620.z6dzyzrlr72kylnn@adacore.com> (Joel Brobecker's message of "Mon, 26 Feb 2018 10:56:20 +0400") Message-ID: <87y3jfpvyh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eqLSR-002HYM-2m X-Source-Sender: 174-29-60-18.hlrn.qwest.net (pokyo) [174.29.60.18]:39228 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00382.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> 2018-02-22 Tom Tromey >> >> * dwarf2read.c (struct variant_field): New. >> (struct nextfield) : New field. >> (dwarf2_add_field): Handle DW_TAG_variant_part. >> (dwarf2_attach_fields_to_type): Attach a discriminant_info to a >> discriminated union. Joel> Looks good to me, Tom. Thanks! Thanks for the reviews. I've updated the patches. Patch #4 needed a minor adjustment to the new complaints to account for the recent 64-bit sect_offset change. Tom