From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] Speed up dict_hash
Date: Wed, 08 Nov 2017 18:44:00 -0000 [thread overview]
Message-ID: <87y3ngr4p7.fsf@tromey.com> (raw)
In-Reply-To: <d3914b48-bdf4-c0c8-7f4e-26f48fcd7acc@redhat.com> (Pedro Alves's message of "Wed, 8 Nov 2017 10:46:29 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> For "gdb -nx -readnow -batch gdb", this improves the time from ~9.8s
>> before to ~8.5s afterward.
Pedro> Nice!
I rebuilt today and the baseline times were higher -- now it starts at
~14.1s for an unmodified gdb, down to ~12.2 with my patch. I'm not sure
if this is due to some other patch, or if the additional time is because
I configured differently (I enabled guile, python, and all targets in
this most recent build). If so, 4 seconds (comparing to the ~10 seconds
last time around) seems awfully expensive for those features...
Pedro> OOC, did you check whether
Pedro> 'if (strcmp (string + 1, "KB") == 0)'
Pedro> or even:
Pedro> if (string[1] == 'K' && string[2] == 'B' && string[3] == '\0')
Pedro> made a difference?
I tried these and they didn't make a difference.
Tom
next prev parent reply other threads:[~2017-11-08 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 16:14 [RFA 0/2] some minor symbol-reading performance improvements Tom Tromey
2017-11-04 16:14 ` [RFA 2/2] Simplify the psymbol hash function Tom Tromey
2017-11-08 11:12 ` Pedro Alves
2017-11-08 11:42 ` Pedro Alves
2017-11-08 19:08 ` Tom Tromey
2017-11-09 14:09 ` Tom Tromey
2017-11-09 14:10 ` Pedro Alves
2017-11-04 16:14 ` [RFA 1/2] Speed up dict_hash Tom Tromey
2017-11-08 10:46 ` Pedro Alves
2017-11-08 18:44 ` Tom Tromey [this message]
2017-11-08 22:41 ` Pedro Alves
2017-11-08 23:01 ` Tom Tromey
2017-11-08 23:51 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3ngr4p7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).