From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90366 invoked by alias); 8 Nov 2017 18:44:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90344 invoked by uid 89); 8 Nov 2017 18:44:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Nov 2017 18:44:07 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 0FCAEB23EC9 for ; Wed, 8 Nov 2017 12:44:05 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CVKXeSfNIrWstCVKXeB03q; Wed, 08 Nov 2017 12:44:05 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:52828 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eCVKX-000wNi-85; Wed, 08 Nov 2017 12:44:05 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Speed up dict_hash References: <20171104161356.17565-1-tom@tromey.com> <20171104161356.17565-2-tom@tromey.com> Date: Wed, 08 Nov 2017 18:44:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 8 Nov 2017 10:46:29 +0000") Message-ID: <87y3ngr4p7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eCVKX-000wNi-85 X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:52828 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00185.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> For "gdb -nx -readnow -batch gdb", this improves the time from ~9.8s >> before to ~8.5s afterward. Pedro> Nice! I rebuilt today and the baseline times were higher -- now it starts at ~14.1s for an unmodified gdb, down to ~12.2 with my patch. I'm not sure if this is due to some other patch, or if the additional time is because I configured differently (I enabled guile, python, and all targets in this most recent build). If so, 4 seconds (comparing to the ~10 seconds last time around) seems awfully expensive for those features... Pedro> OOC, did you check whether Pedro> 'if (strcmp (string + 1, "KB") == 0)' Pedro> or even: Pedro> if (string[1] == 'K' && string[2] == 'B' && string[3] == '\0') Pedro> made a difference? I tried these and they didn't make a difference. Tom