From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Use getenv instead of gdb_environ on mi-cmd-env.c
Date: Mon, 19 Jun 2017 04:15:00 -0000 [thread overview]
Message-ID: <87y3soy5ot.fsf@redhat.com> (raw)
In-Reply-To: <88e26ea4479a02c36d195d9f9e288eb0@polymtl.ca> (Simon Marchi's message of "Sat, 17 Jun 2017 10:01:25 +0200")
On Saturday, June 17 2017, Simon Marchi wrote:
> On 2017-06-17 00:12, Sergio Durigan Junior wrote:
>> This is a spinoff of
>> <https://sourceware.org/ml/gdb-patches/2017-06/msg00437.html>.
>> mi-cmd-env.c is using the whole gdb_environ machinery in order to
>> access just one variable, which can be easily replaced by a simple
>> call to getenv. This patch does that, and doesn't cause regressions.
>>
>> gdb/ChangeLog:
>> 2017-06-16 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of
>> gdb_environ to access an environment variable.
>> ---
>> gdb/ChangeLog | 5 +++++
>> gdb/mi/mi-cmd-env.c | 12 ++++--------
>> 2 files changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
>> index 9062067..f5bf474 100644
>> --- a/gdb/ChangeLog
>> +++ b/gdb/ChangeLog
>> @@ -1,3 +1,8 @@
>> +2017-06-16 Sergio Durigan Junior <sergiodj@redhat.com>
>> +
>> + * mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of
>> + gdb_environ to access an environment variable.
>> +
>> 2017-06-16 Alan Hayward <alan.hayward@arm.com>
>> Pedro Alves <palves@redhat.com>
>> Yao Qi <yao.qi@linaro.org>
>> diff --git a/gdb/mi/mi-cmd-env.c b/gdb/mi/mi-cmd-env.c
>> index 4093178..97be139 100644
>> --- a/gdb/mi/mi-cmd-env.c
>> +++ b/gdb/mi/mi-cmd-env.c
>> @@ -270,21 +270,17 @@ mi_cmd_inferior_tty_show (const char *command,
>> char **argv, int argc)
>> void
>> _initialize_mi_cmd_env (void)
>> {
>> - struct gdb_environ *environment;
>> const char *env;
>>
>> /* We want original execution path to reset to, if desired later.
>> At this point, current inferior is not created, so cannot use
>> - current_inferior ()->environment. Also, there's no obvious
>> - place where this code can be moved such that it surely run
>> - before any code possibly mangles original PATH. */
>> - environment = make_environ ();
>> - init_environ (environment);
>> - env = get_in_environ (environment, path_var_name);
>> + current_inferior ()->environment. We use getenv here because it
>> + is not necessary to create a whole new gdb_environ just for one
>> + variable. */
>> + env = getenv (path_var_name);
>>
>> /* Can be null if path is not set. */
>> if (!env)
>> env = "";
>> orig_path = xstrdup (env);
>> - free_environ (environment);
>> }
>
> LGTM.
>
Thanks, pushed.
1c8e01c96054973c50ec1dec2f220af4734e1de5
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2017-06-19 4:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 22:12 Sergio Durigan Junior
2017-06-17 8:03 ` Simon Marchi
2017-06-19 4:15 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3soy5ot.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).