From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Sanitize input_interrupt output
Date: Mon, 29 Dec 2014 19:25:00 -0000 [thread overview]
Message-ID: <87y4pqi7hd.fsf@redhat.com> (raw)
In-Reply-To: <54A1371C.7000309@redhat.com> (Pedro Alves's message of "Mon, 29 Dec 2014 11:12:28 +0000")
On Monday, December 29 2015, Pedro Alves wrote:
> On 12/28/2014 03:00 AM, Sergio Durigan Junior wrote:
>> On Saturday, December 27 2014, Andreas Schwab wrote:
>>
>>> Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>>
>>>> + {
>>>> + fprintf (stderr, "input_interrupt, count = %d c = %d ", cc, c);
>>>> + if (isprint (c))
>>>> + fprintf (stderr, "('%c')\n", c);
>>>> + else
>>>> + fprintf (stderr, "('\\x%02x)\n", c & 0xFF);
>>> ^
>>>
>>> Missing second quote character.
>>
>> Ops, thanks. Corrected version below.
>
> OK, but please write "0xff" in lowercase.
>
> Thanks!
Pushed with the requested fix.
<https://sourceware.org/ml/gdb-cvs/2014-12/msg00122.html>
fafcc06ab29fe98d2767234dc77062d08ea0d3c7
Thanks,
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2014-12-29 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 5:24 Sergio Durigan Junior
2014-12-27 8:36 ` Andreas Schwab
2014-12-28 3:01 ` Sergio Durigan Junior
2014-12-29 11:12 ` Pedro Alves
2014-12-29 19:25 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4pqi7hd.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).