Re: [PATCH] Don't enable gdbtk in testsuite

[Yao Qi <yao@codesourcery.com>]

Pedro Alves <palves@redhat.com> writes:

> That patch removed it from the git repo, mirroring how CVS modules
> worked.  In CVS, if you checkout the "gdb" module, you don't get
> the gdbtk dirs, but if you checkout the insight module instead, you
> get everything gdb, plus the insight bits: src/gdb/gdbtk subdir,
> src/gdb/testsuite/gdb.gdbtk/, and maybe other bits.

Hi Pedro,
I looked at insight and the date of the last commit in
gdb/testsuite/ChangeLog is 2013-10-21.  Looks insight stops updating gdb
after gdb migrates to git so I think it should be safe to remove
testsuite gdbtk from gdb head.

>
> So removing the testsuite support for gdbtk doesn't seem like
> the right thing to do.  Particularly since we still have the
> gdbtk bits in gdb/configure.ac.  IOW, I don't see how
> src/gdb/testsuite/gdb.gdbtk/ not being around is different
> from src/gdb/gdbtk/ not being around.  We should either keep
> all support for gdbtk, or remove all of it.

It is aggressive to remove gdbtk bits from gdb/configure.ac, although
there were some "insight end-of-life" discussions on insight mail list.
I am OK to revert my patch.

-- 
Yao (齐尧)