From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1251 invoked by alias); 5 Dec 2014 06:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1241 invoked by uid 89); 5 Dec 2014 06:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Dec 2014 06:55:52 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Xwmns-00011v-Q3 from Yao_Qi@mentor.com ; Thu, 04 Dec 2014 22:55:48 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Thu, 4 Dec 2014 22:55:48 -0800 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH] Don't enable gdbtk in testsuite References: <1416903049-30419-1-git-send-email-yao@codesourcery.com> <548094B1.8050708@redhat.com> Date: Fri, 05 Dec 2014 06:55:00 -0000 In-Reply-To: <548094B1.8050708@redhat.com> (Pedro Alves's message of "Thu, 4 Dec 2014 17:06:57 +0000") Message-ID: <87y4qmd1qu.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00118.txt.bz2 Pedro Alves writes: > That patch removed it from the git repo, mirroring how CVS modules > worked. In CVS, if you checkout the "gdb" module, you don't get > the gdbtk dirs, but if you checkout the insight module instead, you > get everything gdb, plus the insight bits: src/gdb/gdbtk subdir, > src/gdb/testsuite/gdb.gdbtk/, and maybe other bits. Hi Pedro, I looked at insight and the date of the last commit in gdb/testsuite/ChangeLog is 2013-10-21. Looks insight stops updating gdb after gdb migrates to git so I think it should be safe to remove testsuite gdbtk from gdb head. > > So removing the testsuite support for gdbtk doesn't seem like > the right thing to do. Particularly since we still have the > gdbtk bits in gdb/configure.ac. IOW, I don't see how > src/gdb/testsuite/gdb.gdbtk/ not being around is different > from src/gdb/gdbtk/ not being around. We should either keep > all support for gdbtk, or remove all of it. It is aggressive to remove gdbtk bits from gdb/configure.ac, although there were some "insight end-of-life" discussions on insight mail list. I am OK to revert my patch. --=20 Yao (=E9=BD=90=E5=B0=A7)