From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] move the entry point info into the per-bfd object
Date: Mon, 13 Jan 2014 20:51:00 -0000 [thread overview]
Message-ID: <87y52jzjtv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52CD530D.6050903@redhat.com> (Pedro Alves's message of "Wed, 08 Jan 2014 13:30:53 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think this has reached sufficient levels of indirection
Pedro> that if I were writing this, I'd do:
Pedro> static void
Pedro> init_entry_point_info (struct objfile *objfile)
Pedro> {
Pedro> + struct entry_info *ei = &objfile->per_bfd->ei;
Pedro> and then use ei-> throughout the function instead, like:
Thanks, I made this change.
Tom
next prev parent reply other threads:[~2014-01-13 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 20:30 [PATCH 0/3] move entry point info to the per-BFD object Tom Tromey
2014-01-06 20:30 ` [PATCH 2/3] relocate the entry point addess when used Tom Tromey
2014-01-08 13:22 ` Pedro Alves
2014-01-13 20:46 ` Tom Tromey
2014-01-15 11:42 ` Pedro Alves
2014-01-15 17:59 ` Tom Tromey
2014-01-15 18:02 ` Pedro Alves
2014-01-06 20:30 ` [PATCH 1/3] change solib-frv to use entry_point_address_query Tom Tromey
2014-01-08 13:23 ` Pedro Alves
2014-01-06 20:30 ` [PATCH 3/3] move the entry point info into the per-bfd object Tom Tromey
2014-01-08 13:30 ` Pedro Alves
2014-01-13 20:51 ` Tom Tromey [this message]
2014-01-15 18:01 ` [PATCH 0/3] move entry point info to the per-BFD object Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y52jzjtv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).