From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] New "make check-headers" rule.
Date: Thu, 14 Nov 2013 21:32:00 -0000 [thread overview]
Message-ID: <87y54qvfw1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5283CD04.3080501@redhat.com> (Pedro Alves's message of "Wed, 13 Nov 2013 19:03:32 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> New "make check-headers" rule.
It seems like a good idea to me.
Pedro> +check-headers:
Pedro> + @echo Checking headers.
Pedro> + for i in $(CHECK_HEADERS) ; do \
Pedro> + $(NODEPS_COMPILE) -Wno-error $(PYTHON_CFLAGS) -include defs.h \
Pedro> + $(srcdir)/$$i -o /dev/null ; \
Pedro> + done
I'm curious why -Wno-error.
Also why not -fsyntax-only?
... neither of which I think are blockers.
It's fine to refine this later.
Tom
next prev parent reply other threads:[~2013-11-14 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 6:38 [RFA/commit 1/3] language.h: Add "symtab.h" #include Joel Brobecker
2013-11-11 6:39 ` [RFA 2/3] New function cli-utils.c:extract_arg_const Joel Brobecker
2013-11-13 19:35 ` Pedro Alves
2013-11-14 10:55 ` pushed: " Joel Brobecker
2013-11-11 6:55 ` [RFC 3/3] GDB/MI: Add new "--language LANG" command option Joel Brobecker
2013-11-11 7:02 ` Joel Brobecker
2013-11-11 17:20 ` Eli Zaretskii
2013-11-11 16:29 ` Eli Zaretskii
2013-11-13 19:49 ` Pedro Alves
2013-11-14 11:17 ` Joel Brobecker
2013-11-13 19:34 ` [PATCH] New "make check-headers" rule. (was: Re: [RFA/commit 1/3] language.h: Add "symtab.h" #include) Pedro Alves
2013-11-14 10:00 ` Joel Brobecker
2013-11-14 21:32 ` Tom Tromey [this message]
2014-01-13 19:42 ` [PATCH] New "make check-headers" rule Pedro Alves
2013-11-14 10:55 ` pushed: [RFA/commit 1/3] language.h: Add "symtab.h" #include Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y54qvfw1.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).