From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107227-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13849 invoked by alias); 14 Nov 2013 21:21:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13837 invoked by uid 89); 14 Nov 2013 21:21:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 21:21:28 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAELLJmk031877	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 14 Nov 2013 16:21:19 -0500
Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAELLIho002870	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 14 Nov 2013 16:21:19 -0500
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] New "make check-headers" rule.
References: <1384151855-12926-1-git-send-email-brobecker@adacore.com>	<5283CD04.3080501@redhat.com>
Date: Thu, 14 Nov 2013 21:32:00 -0000
In-Reply-To: <5283CD04.3080501@redhat.com> (Pedro Alves's message of "Wed, 13	Nov 2013 19:03:32 +0000")
Message-ID: <87y54qvfw1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-11/txt/msg00394.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> New "make check-headers" rule.

It seems like a good idea to me.

Pedro> +check-headers:
Pedro> +	@echo Checking headers.
Pedro> +	for i in $(CHECK_HEADERS) ; do \
Pedro> +		$(NODEPS_COMPILE) -Wno-error $(PYTHON_CFLAGS) -include defs.h \
Pedro> +			$(srcdir)/$$i -o /dev/null ; \
Pedro> +	done

I'm curious why -Wno-error.
Also why not -fsyntax-only?

... neither of which I think are blockers.
It's fine to refine this later.

Tom