From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 77FAE384640E for ; Wed, 24 Apr 2024 21:39:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77FAE384640E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77FAE384640E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713994780; cv=none; b=u2mbzO8/0dqroC9xLgJftT774bS8I8XpXkGJY3VyyGDxY3W3jquHovekpfxpfAuaFn+43p/pe1X7ydp6ZWac63rVpHNQ5yaDKL5mo1bcbeO00dL7lDNRNiRoLv12omxIdYrnfgHefe/K7RJcIqvoB0nFR0SdBziq4ZYoe6krG1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713994780; c=relaxed/simple; bh=8zsGaDuUCK6uDiMig1erB12SaZET60xCzditYTamuGk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xJu2EWB1wmG7blNfaWafbgAJ2/WfGCRen/q20z9aJYHuCKfV7FpcfXGgAJ2DBmHdtX89g1AuLKBenfRGo1UR+0+uhYRWA72F6/e9kYchnZbNAJw4A7Ot2aqrUSqqQEYhubPRYowARwNxsYJ9n76MXTCA/n2u5lNGjwKIUvgNZT4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id zKbLrOVQQQr4SzkL2rOav5; Wed, 24 Apr 2024 21:39:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zkL1rojp1sT9BzkL1rZABE; Wed, 24 Apr 2024 21:39:36 +0000 X-Authority-Analysis: v=2.4 cv=LIutQ4W9 c=1 sm=1 tr=0 ts=66297c18 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=aBVRsjN-LeXbpUNX9awA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jj9f+eQcQZ17lfzhuX0toOsV/eyHFePlKZo5lZ+SfCw=; b=prHBk6RskMRC/S0U7Pzk3tUo8V Jti6Du1jdTy6W0tkfNn+cWyubmU9t+O+zB8MxvMSZHeYQqpzV3Lo8nBjjvgwX/zxIgLdmmtcCik5e X1Rqbs57s9pe1GNjFF29NMHqa; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:60302 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rzkL1-001OHy-0d; Wed, 24 Apr 2024 15:39:35 -0600 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/remote: fix qRcmd error handling In-Reply-To: <87v847u9q9.fsf@redhat.com> (Andrew Burgess's message of "Tue, 23 Apr 2024 21:04:14 +0100") References: <8734rdsb51.fsf@tromey.com> <87v847u9q9.fsf@redhat.com> X-Attribution: Tom Date: Wed, 24 Apr 2024 15:39:34 -0600 Message-ID: <87zfticueh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rzkL1-001OHy-0d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (prentzel) [97.122.86.252]:60302 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLuSHQUVAgjRzgI72psBlu99PmUcRAY+X+QEEhemt67ys15qNRmKghFQUes9tx5qwTKcgwiaJOgHVK0n6kTfuuEyTQJ3gUexj6BvPV9vcDaHKMRf7gRQ MBVZAgaRcJVlmELNcgEuqgyFnEOY+vYBTDmH6sBPLyKn+4y28F86oCVabD+rvkGlmIzru0QpeyFLpA0XJRS5K2aY4VTORJnjt2Q= X-Spam-Status: No, score=-3015.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> The patch itself seems reasonable to me, but at the same time, isn't the >> behavior you describe also fine? >> >> The docs describe "OK", other "O" output packets, the "E" response, and >> the empty response. It seems to me that any other response could >> reasonably be treated as an error. Andrew> The behaviour I'm restoring is documented, see the 'OUTPUT' entry in the Andrew> 'Reply:' list: Andrew> 'OUTPUT' Andrew> A command response with the hex encoded output string OUTPUT. I thought your patch was concerned with changing the output of responses other than 'E' or 'O'... did I misunderstand that? Tom