From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 2A0EE3858C3A for ; Thu, 14 Mar 2024 12:43:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0EE3858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0EE3858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710420198; cv=none; b=wzo71iG5EpzDI/VC4ECP+6cdN72qXuErFPnrr6YaV8MHiIZha2rZ9E61UbsZi3UdLhgtuRBr2vdd4dsUWWxfD+z1gyJB3hTi4Ey3lkU0FWVBeFtkMhuwncvnkgRDvl2N6oda/TDEk9vOk+yB746ph5ciU6BzLWwFNATRl80vu6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710420198; c=relaxed/simple; bh=HsW+ZeFUK7D3Y/+mYfrmfgcWkEOkvuslyPDL9hkZeWo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aNgGPZFqGrw47HfjYs5OQ3iiJm9zqRx5hqeekAvWaVFZcJr13cQ0twAGhZ94Nl6vIK9hvuiNfH4jbm2Xlx8SVyywqBOqqCqt252hLm6FK1XMXS5ZarJZ4GtHy21lVK8C5s73MEDg/QjP5CrbIws2gs81NV/F3M0uus352/t1Pq4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id kiNWrrBreuh6skkQVrevTW; Thu, 14 Mar 2024 12:43:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kkQUrFP6gWxyYkkQUrGAXZ; Thu, 14 Mar 2024 12:43:14 +0000 X-Authority-Analysis: v=2.4 cv=Co65cG4D c=1 sm=1 tr=0 ts=65f2f0e2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=vpIfQ3Ol0iqFPXCExTsA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3W9jzHCtkbcfR53o0AwD2JYrYteIUR6NSc5TcHyarLQ=; b=dPqu3yWJwYDq/2TLwdHIqHMlUn x6AlIW2cylQoY0LVN0a30Y0c3HIVEqHlM+pTkSzhqxa7EtZxqaOyuXGBXa+nij+phHACd7kGg6Zv8 z7U06Gi336I/F86rFFdjea+3r; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:39002 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rkkQU-002eRk-0e; Thu, 14 Mar 2024 06:43:14 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/build] Fix build on postmarketos References: <20240314095440.23256-1-tdevries@suse.de> X-Attribution: Tom Date: Thu, 14 Mar 2024 06:43:13 -0600 In-Reply-To: <20240314095440.23256-1-tdevries@suse.de> (Tom de Vries's message of "Thu, 14 Mar 2024 10:54:40 +0100") Message-ID: <87zfv1kmqm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rkkQU-002eRk-0e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:39002 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGX+n6h5i/Ujj9P5uEgP12moFuuomCnxYJJQq/tuAR74URkUW+ngzuCbq1ADLiipI6IIs/nh2ZDS//WbSyeBweSiD21/B7ZvShOshEppSbO9HARDK3GO WCYNIx73ww290PWWmOz/nsthwRcr7nqM1zquAju9EMDoNCT8qB41YQx+iOy0z48Rf3zgshAruufhr9Bwh3nXS5zk9W7Skj8PXu8= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> I tried building gdbserver on postmarketos (which is based on alpine linux, Tom> which uses musl libc), and ran into: Tom> ... Tom> gdbserver/linux-low.cc: In lambda function: Tom> gdbserver/linux-low.cc:1907:41: error: \ Tom> 'W_EXITCODE' was not declared in this scope Tom> 1907 | mark_lwp_dead (leader_lp, W_EXITCODE (0, 0), true); Tom> | ^~~~~~~~~~ Tom> ... Tom> The macro W_EXITCODE is not defined in gdbsupport/gdb_wait.h, but WSETEXIT is: Tom> ... Tom> /* These are not defined in POSIX, but are used by our programs. */ Tom> #ifndef WSETEXIT Tom> # ifdef W_EXITCODE Tom> #define WSETEXIT(w,status) ((w) = W_EXITCODE(status,0)) Tom> # else Tom> #define WSETEXIT(w,status) ((w) = (0 | ((status) << 8))) Tom> # endif Tom> #endif Tom> ... I think it'd be better to change this to define W_EXITCODE. WSETEXIT isn't used in the tree at all AFAICT. Tom