From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 5BEDF3858287 for ; Tue, 27 Feb 2024 14:13:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BEDF3858287 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5BEDF3858287 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709043194; cv=none; b=XdmMYIBGbJ5OGfOioGn3enJJuR8yFaGkOy9ZWUahm78YPzwLZ/Irmc+X+QVv5m2jhDxA+iYW3M4e/FuuB5YtsPf4MQIwrSVjcYg5kjUWsGYSGMrCvcHGMCqDXXAtS5fJOln0BFeMgPHVtjEFdE0O5gVRrYb7cacgkSjpPTjsnjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709043194; c=relaxed/simple; bh=W1jbjgoXTZOO62jCADMWfYbN04xZzydvm4UNLXatV7Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=V1uFbop0Vt0N7pZT25zENiBi8kB8dUIDRGzfq01ERBb/kKFKMNKZlzp6312CmCqq6v+s2tnnkVQDuPWO6zurGq7QNcudcgXrrDRZzuX2A56qPAQvhFJr+FvBBEUT68uJ/tjEqSTYHDlnwcWPA29hdxLXMYkEbJN/N8ICK2JUvKI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id exfcrbPpouh6seyCnrBYSd; Tue, 27 Feb 2024 14:13:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id eyClrWDeGHfYYeyCmrBFd9; Tue, 27 Feb 2024 14:13:12 +0000 X-Authority-Analysis: v=2.4 cv=EvfUrzcA c=1 sm=1 tr=0 ts=65ddedf8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=waAyduaqQLqSkc4kjykA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YzWBsn0Arcc+HCRfBEnrTOMjW7oe+M7OeM21ywKyELY=; b=BnMNliLqYBhwItxIDIz9yPlAug RgUYFvJ2WEifDmfoBN+TY4igfMyu6BJWd3l6gyQy8Z2r/jkcedM6wmnhKwSDWCPsJNWB4hK5r8U/2 lIuu8Z78Uoo1v+N9gZnGrlHTu; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:50724 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1reyCl-003Zlo-1m; Tue, 27 Feb 2024 07:13:11 -0700 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Takashi Yano Subject: Re: [PATCH] Cygwin: Fix putting inferior in foreground (fix input) References: <20240226204445.1324953-1-pedro@palves.net> X-Attribution: Tom Date: Tue, 27 Feb 2024 07:13:10 -0700 In-Reply-To: <20240226204445.1324953-1-pedro@palves.net> (Pedro Alves's message of "Mon, 26 Feb 2024 20:44:45 +0000") Message-ID: <87zfvmuhah.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1reyCl-003Zlo-1m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:50724 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNvP1YB5wbxfqrg/xxG+4pxbG7gJbCM4KDfc+i5o7VCMRoBo8irUysXeJod7xkfRpz2lc/MKSUYzwq7EoS543rFXyegNFY2/xXrpLEq1aJlaLHJrXUOt MlCHx3uh65IphlO/uhIoKGCXraAIHBAlPFwF5e1mBNFK+Sb9QaLeBa2nbCJxtF6x4DCieFsLT1aTv/nQYftAJjSoeUyj5VbgdIg= X-Spam-Status: No, score=-3016.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> The problem is that inflow.c:child_terminal_inferior is failing to put Pedro> the inferior in the foreground, because we're passing down the Pedro> inferior's Windows PID instead of the Cygwin PID to Cygwin tcsetpgrp. Thanks. My first thought was that this should really be target-specific, but I dug into the code and I see that this is only called from inf_child_target -- i.e., it is. I wonder if a bunch of that code could be moved out of inflow.c and into inf-child.c. Approved-By: Tom Tromey Tom