From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid an allocation in attr_to_dynamic_prop
Date: Mon, 05 Feb 2024 12:12:08 -0700 [thread overview]
Message-ID: <87zfwen2t3.fsf@tromey.com> (raw)
In-Reply-To: <102caf32-62c3-4460-b30b-2c4da40b72f0@suse.de> (Tom de Vries's message of "Mon, 5 Feb 2024 05:36:04 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> But I suppose you could consider doing the micro-optimization of:
Tom> ...
Tom> - struct dwarf_block *block;
Tom> + struct dwarf_block local_block;
Tom> + struct dwarf_block* block = &local_block;
Tom> ...
Tom> and keep the pointer copy.
IME these micro-optimizations don't really affect the outcome much. I
tried a bunch like this back in the psymtab days without real effect.
Probably the baton should have a dwarf_block object and then there'd
just be a single copy here.
Tom> Reviewed-By: Tom de Vries <tdevries@suse.de>
Thanks
Tom
prev parent reply other threads:[~2024-02-05 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 19:15 Tom Tromey
2024-02-05 4:36 ` Tom de Vries
2024-02-05 19:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfwen2t3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).