From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 06CCD3858D20 for ; Tue, 14 Nov 2023 15:53:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06CCD3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06CCD3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699977239; cv=none; b=iaQkGbC97nwdLdMSHa0DpSuRACtbOFgGC1xKl+NTxrUJc7VMV9G+C0B9z4+1/FN7rJijwqwvNC+PcAFTwd2ugz9IEbP4LF7LzeAH5FnmgDbhonXs2wSjqlaUpwyAMjGKZXwyXYPh7y5e8BiNzStJ2B64TfwRP2Pn/cUQ89en0rc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699977239; c=relaxed/simple; bh=ZuwCRqfs6C0bP4Ce4s/pn/zGvBA/WUJU6Nke1qwmtng=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bUnO5mrixWEgG3cws6W0NeDAY2ghcVrDCIdWeVuWxdJdxYZZ+6XM4pr4Yj+tG6tnBqqU9es/Y9+B3WRT281aeip4z8i8pccmE/GARI2FEn/VxOZKjTXuQgD+kZUYE6Vj3z0yC2WibqL9xmujK0AFm9DHUvn7JxyrDhDaakQepQU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-359398abeb5so20634145ab.1 for ; Tue, 14 Nov 2023 07:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699977237; x=1700582037; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GwgOfGQuBUiQbmyFvJuM6muAWLLJ76EhigtyFs2wRKA=; b=kSezpBeAFGNnFJ1QFmp2BvqTSQIQLPSxyK6YHfo32TNJq5hvJM0b5rgsAZ1gOk0BGo ridZ9KneAUgDvak1aR3LtrEkuqpEzdh08VP9awffOUwHmt+leyo0atz7E/IuTen8slQx VMJSkcuynMGlEIgOSGKhH5iJAijrlxOr+cwr/7Eng642A0MaNFHr5B8exNIiGwel/U0a iukRxSOy151MX2kh/dupibJ/d77NowUyq25RnZfZj4j8kqEFIxn5Oc1yDKf7I6fklS+u 2d6Xl9yLzSiEuGg3PggvOQ17gZOeSxXzA8uBwkmzfpFxgM+w1qrpKHRkwoBr5ZTmFq1y 2+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699977237; x=1700582037; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GwgOfGQuBUiQbmyFvJuM6muAWLLJ76EhigtyFs2wRKA=; b=DrfisEcJzf+W7dufnpPs06k2FKZgn3iaZSwxy7q6GbPX9cueiefi2Tff2MhdWsYBSK vGTg+gkTcWKOhFMY5SmL198Oblh1WWGaxImveMhFHJvT6JSBDhT1Xva0dbAEiL4noIL9 AwQi+zvfidcQXRpbczKmT8auJ6QV20egYXT6+q3UYzP9+rEwzakKwGMgv0ONwwFu6sbF F/gaLXyUtz3GPV7/Mfky3IVyvg64eJ7Cw5YKvRD8u1CbOhZvZz1n/O5yUstftKdR8thZ yGQKrp/HY1DR82Urcxcl22X9a1FTB1fMEtXMRBYT/JD91dZO4UaMtlaXJtMOM1rymLxD IfNQ== X-Gm-Message-State: AOJu0YxQuyHAVe9b6RDPDJkLWKNqLe7lvasN9tScH/5pA9Lp8TJHxO+u GUwob6om/VhHtum7kRaME0ygFo7WlZt0to0ltx/fBg== X-Google-Smtp-Source: AGHT+IGFhZbbtqDP4Nd6EXpo6yEcy1GL6fr7Um6YmvxhiEGRt1OHpoenrKUFSulkY5UKntWZBYN8tw== X-Received: by 2002:a05:6e02:1607:b0:35a:a534:916a with SMTP id t7-20020a056e02160700b0035aa534916amr15809201ilu.6.1699977237271; Tue, 14 Nov 2023 07:53:57 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id o20-20020a02cc34000000b0045bc0378faasm473693jap.29.2023.11.14.07.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 07:53:56 -0800 (PST) From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: remove two uses of obstack References: <20230412202701.349105-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 14 Nov 2023 08:53:56 -0700 In-Reply-To: <20230412202701.349105-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Wed, 12 Apr 2023 16:27:01 -0400") Message-ID: <87zfzgpbzf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Remove uses of obstack in the code generating the libraries XML for Simon> Windows and AIX. Use std::string instead. I'm not able to test this Simon> change, unfortunately. Came across this unreviewed patch. I think it is ok. Also, it's early after the branchpoint, so this is a good time to put it in if you are unsure. At least the Windows code will be tested here at AdaCore sometime after merging. Tom