From: Tom Tromey <tom@tromey.com>
To: Alexandra Petlanova Hajkova via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>,
Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Subject: Re: [PATCH] Add DAP scope cache
Date: Mon, 16 Oct 2023 08:41:26 -0600 [thread overview]
Message-ID: <87zg0isk89.fsf@tromey.com> (raw)
In-Reply-To: <CAJVr-ENENuEJzJeEREykMdgwZTTvRSRFvJRhngy-d_JpwXi_Gw@mail.gmail.com> (Alexandra Petlanova Hajkova via Gdb-patches's message of "Tue, 3 Oct 2023 14:16:48 +0200")
>>>>> "Alexandra" == Alexandra Petlanova Hajkova via Gdb-patches <gdb-patches@sourceware.org> writes:
>> Andry Ogorodnik, a co-worker, noticed that multiple "scopes" requests
>> with the same frame would yield different variableReference values in
>> the response.
>>
>> This patch adds a regression test for this, and adds a scope cache in
>> scopes.py, ensuring that multiple identical requests will get the same
>> response.
Alexandra> I tested this on ppc64le (Power 10) with Fedora Rawhide and I can confirm
Alexandra> there're no regressions and the gdb.dap/scopes.exp all passes.
Thanks. I've added a Tested-By with your email, and I'm going to check
this in. I'm also going to push it to the gdb 14 branch -- I plan to do
this with the DAP fixes generally, since it is a new feature.
Tom
prev parent reply other threads:[~2023-10-16 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 18:36 Tom Tromey
2023-10-03 12:16 ` Alexandra Petlanova Hajkova
2023-10-16 14:41 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg0isk89.fsf@tromey.com \
--to=tom@tromey.com \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).