From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 2F7003858D38 for ; Mon, 11 Sep 2023 18:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F7003858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-34deefc2016so14646025ab.2 for ; Mon, 11 Sep 2023 11:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694455653; x=1695060453; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZMxMezhklviluoZseTqhprVYvL3ZtNgjHbMlGY6d3To=; b=g5OWP5yFxMPhhKb5URxTf7Lr2LmhJM8AS7HLLtoJ9jIfVM9Bt2JFaDzhqq8E5EMYAR NlDslkdh2Y0G+2BhC3ogbhgPz/hfmeoRWKWA/yvlD9FB7CIRV9zkzJ0w6isMI1s98/Bf 5cwjfr3PeZbxzwz3g31bNQDyAJve150UoHEYfFDDhvIilMIBNgKosZv/E/9BgZAYpJVd DCwqsnK4DJOKFXxUHmFfqpJMZ49Es8Wjiu9LWQcQGVceQ632YLFAbO8HffXCdMXyIDYq 3e7U4Gi/xh188F+omgmVwRF/gcAEtPw2i9R0GbUCKWPXXta4KoifLEeYYMr+QVnWF289 XZkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694455653; x=1695060453; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZMxMezhklviluoZseTqhprVYvL3ZtNgjHbMlGY6d3To=; b=C+Uzp9xE2oGanusDbRzf6LMlVviRdTq/RjS1mvvMG0qxnuxZ/jZvLMgGMb6Vzu2r3W gtOcN+D3R9VgOBFA1HP3GN3S7cKveyCS2+Ets9RufzHlsEkVGtVWwd7mBwVEelfe1ukg 5Qn28Ogs6qYw62Y30viVVFmoFskrXJu0sISIHoqfOMNcm+0mFzcIhdHVTcYk7V89ultR xQX0WdVTb8LkpUMPzbLm28bHgqIbMR4FYQSmzFpQ+06CDhFEgEirI/uc6tCtPiA1/AgC 5A2AeUPJndwGacZxFS+tyZlF4KtOYxQ4PjCRbuWBFzjTt8QfhAlQMyP7RRyhsUnYiO93 U+TQ== X-Gm-Message-State: AOJu0Yz1mznn0ojTaDCsA5/bamUgB2FKHd3cl3etIcpPjyP0oYl0uGBL 6Qf1XKXg/cj+GCLasOIEcqGZyA== X-Google-Smtp-Source: AGHT+IHApT+bd+cs/Xj0cZB2MHmQ/5aW/xeHfVS26Hi4a7feJYl/SwcLIBcxEiDmw6pJyiDZEbrvoA== X-Received: by 2002:a05:6e02:20ca:b0:34a:c2e2:b2a7 with SMTP id 10-20020a056e0220ca00b0034ac2e2b2a7mr12170480ilq.25.1694455653493; Mon, 11 Sep 2023 11:07:33 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id p20-20020a927414000000b00348ab9bd829sm1367866ilc.53.2023.09.11.11.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 11:07:32 -0700 (PDT) From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre , tromey@adacore.com Subject: Re: [PATCH v4] gdb/DAP Introduce new methods to to Pretty Printers References: <20230626153108.193139-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Mon, 11 Sep 2023 12:07:31 -0600 In-Reply-To: <20230626153108.193139-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Mon, 26 Jun 2023 17:31:08 +0200") Message-ID: <87zg1sk2ho.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Farre via Gdb-patches writes: Simon> This patch introduces the `num_children` method to the NoOpArray-pretty Simon> printer as well as fixing a bug where some types accidentally uses Simon> NoOpScalar pretty printers. It also cleans up the retrieval of variables Simon> during a "variables" request (or an "evaluate" request) reducing the Simon> complexity. We discussed it a bit earlier, but basically I think we can't add methods to pretty-printers without a bit of extra work. I recently implemented this though. Would you mind looking at this series? https://sourceware.org/pipermail/gdb-patches/2023-September/202342.html If/when this lands we can start the process of updating the various pretty printers out in the wild. Tom