From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 666CC3858D20 for ; Thu, 7 Sep 2023 18:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 666CC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7927f36120cso52891539f.1 for ; Thu, 07 Sep 2023 11:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694111767; x=1694716567; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hkYfQ/+J4YPWxBSkNKIB/ufKsfdtNFXBYY2I0M5BRqI=; b=RZ89MSx0+byTrgLKfPzoFsNMIJmwlQRbA0N9PeeyCziKfA0uumtJPoRTur9IwlYvuv 51ZVlxSQ77h/aicrvV0M4K1mkGFBC6A6kfDC8FGL1kzWfotJGq6jOzXaxxCN7sg26I4+ p39c+CfQCnghCJNSd5Ug+9T3fdsrCvNPAYRgq/WW1LFZ2zG+fmsBC7THaAfl3R+Htqbg SVVwX4xB00aFWSViYHk5WsstrSjFdZDwjjO6+9vPchuyeeyKJuJ+sISUOP/y9bE4xyCY sS0xZ4edFO6tykgZX4GzO0Fs4AmKWmHLWoDc1fOQFyW47glT7agNZ2dUBuwLDYrTyPG6 X1DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694111767; x=1694716567; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hkYfQ/+J4YPWxBSkNKIB/ufKsfdtNFXBYY2I0M5BRqI=; b=gvW1VZBF2RDR0SRXCt/jkBSuSOYMKC2ER0uQeumEZI+i3c4RyD7OfehM+AQ+2pOeD6 7yxZNKbMJMPQHbCBKROSVBcT7mksDGb2vVK5psyVp89w2yqJ/1HbSqgMLMBg/UU82Qsl x8Sax0Z1HIWAQI7q+D1vidfrM8hgrGpkvO9Y///3oabhEbD8MtU+eUU4OSGa8FYGMmDQ GWYTis2pHzV8WnTvoIwdO3fXUwSquk4oRNEw2id1Prb1gEGD3/OCMhFOZTnWOvmtDzRi UEscR6GJtINRuRTmWuEZ331Ihh5AODQHqygXaXSpF/UhE1tSv9IAzVAaOk2f4kvL3L8K JyAQ== X-Gm-Message-State: AOJu0Yy0FQspFCKt7/zuoz3MvzfnvsJYiGSRr6Gnkwr1ONeQaufkajMv PZRBSY7tQviwLNam2Y2il2CoeA== X-Google-Smtp-Source: AGHT+IEV6cYisLZ2tftEHp7BYcIA7wZwlBX39SwfkIRWXAJSCNb2gMlueC0WK/57WvSbOcO4yN5kUw== X-Received: by 2002:a6b:ea07:0:b0:792:9333:2cbf with SMTP id m7-20020a6bea07000000b0079293332cbfmr582285ioc.6.1694111767724; Thu, 07 Sep 2023 11:36:07 -0700 (PDT) Received: from murgatroyd (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id v5-20020a5ec105000000b007911db1e6f4sm15915iol.44.2023.09.07.11.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 11:36:06 -0700 (PDT) From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH] [gdb/ada] Extend type equivalence test in ada_resolve_enum References: <20230907144233.14505-1-tdevries@suse.de> X-Attribution: Tom Date: Thu, 07 Sep 2023 12:36:05 -0600 In-Reply-To: <20230907144233.14505-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Thu, 7 Sep 2023 16:42:32 +0200") Message-ID: <87zg1xltka.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> When using target board debug-types, the enums E1 and E2 are replicated in the Tom> .debug_types section, and consequently in ada_resolve_enum the type Tom> equivalence check using a pointer comparison fails: Tom> ... Tom> for (int i = 0; i < syms.size (); ++i) Tom> { Tom> /* We already know the name matches, so we're just looking for Tom> an element of the correct enum type. */ Tom> if (ada_check_typedef (syms[i].symbol->type ()) == context_type) Tom> return i; Tom> } Tom> ... Tom> Fix this by also trying a structural comparison using Tom> ada_identical_enum_types_p. Thank you. I think this is ok. Approved-By: Tom Tromey Tom