From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id DD69E38582AC for ; Mon, 14 Aug 2023 16:00:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD69E38582AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id DCC4F10044451 for ; Mon, 14 Aug 2023 16:00:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VZzLqwEAQUihBVZzLqMl4N; Mon, 14 Aug 2023 16:00:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=KoyIZUaN c=1 sm=1 tr=0 ts=64da4f8f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=piVccgeRAydobJgAV2IA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KkSb5fkN96XrsBM1HgiPTWpSDPhbbKeCdlgm6Laf5Zs=; b=x/z7WGhTwSly9orAy+RN9wACdO fJoQR2NplSaMMyB9Vma0LYxROSaEsssQZBr1xoZtFbFdpCpQx9RjA7Gj4w54FAKCicWaZAsGmJwCJ qRxTgLaAunsR0YnPSgW6EFhtX; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:33614 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qVZzL-002T8X-1D; Mon, 14 Aug 2023 10:00:15 -0600 From: Tom Tromey To: Kevin Buettner via Gdb-patches Cc: Kevin Buettner , Simon Marchi Subject: Re: [PATCH v3 1/2] [symtab/27831] Fix OBJF_MAINLINE assert References: <20230813035925.3344167-1-kevinb@redhat.com> <20230813035925.3344167-2-kevinb@redhat.com> X-Attribution: Tom Date: Mon, 14 Aug 2023 10:00:14 -0600 In-Reply-To: <20230813035925.3344167-2-kevinb@redhat.com> (Kevin Buettner via Gdb-patches's message of "Sat, 12 Aug 2023 20:48:52 -0700") Message-ID: <87zg2tzka9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qVZzL-002T8X-1D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:33614 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Kevin" == Kevin Buettner via Gdb-patches writes: Kevin> This commit fixes a bug mentioned by Florian Weimer during the Kevin> libpthread/ld.so load order discussion from 2021. Florian provided Kevin> instructions for reproducing the bug here: Thanks for the patch. I think this looks good but I had one possible concern. Kevin> diff --git a/gdb/elfread.c b/gdb/elfread.c Kevin> index 349a8b75bcc..dbe5951c802 100644 ... Kevin> - result->maybe_copied = 1; Kevin> +bool Kevin> +minimal_symbol::maybe_copied (objfile *objfile) const Kevin> +{ Kevin> + return ((objfile->flags & OBJF_MAINLINE) == 0 Kevin> + && (m_type == mst_data || m_type == mst_bss)); The old approach was specific to ELF, while the new approach will be used by any object format. I am not sure if other object formats even have copy relocs. Do they? If so then this seems fine. If not, then it seems like it could result in an incorrect evaluation in some scenario. Tom