From: Andrew Burgess <aburgess@redhat.com>
To: Greg Savin via Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org, binutils@sourceware.org,
palmer@dabbelt.com, greentime.hu@sifive.com,
John Baldwin <jhb@freebsd.org>
Cc: Greg Savin <greg.savin@sifive.com>
Subject: Re: [PATCH v2 1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6
Date: Fri, 11 Aug 2023 13:23:09 +0100 [thread overview]
Message-ID: <87zg2xdaz6.fsf@redhat.com> (raw)
In-Reply-To: <20230810221122.1155980-2-greg.savin@sifive.com>
Greg Savin via Binutils <binutils@sourceware.org> writes:
> ---
> include/elf/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/elf/common.h b/include/elf/common.h
> index ffa6b60bd2b..e7eede23a07 100644
> --- a/include/elf/common.h
> +++ b/include/elf/common.h
> @@ -714,7 +714,7 @@
> #define NT_LARCH_LBT 0xa04 /* LoongArch Binary Translation registers */
> /* note name must be "CORE". */
> #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */
> - /* note name must be "LINUX". */
> + /* note name must be "GDB". */
I'm not a binutils maintainer, so can't approve this, but did originally
add NT_RISCV_CSR.
FWIW, this change LGTM.
Thanks,
Andrew
> #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */
> #define NT_FILE 0x46494c45 /* Description of mapped files. */
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-08-11 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:53 [PATCH] Re-map value of NT_RISCV_CSR to not collide with the value of NT_RISCV_VECTOR in Linux kernel header file 'include/uapi/linux/elf.h' Greg Savin
2023-08-10 18:39 ` John Baldwin
2023-08-10 18:56 ` Greg Savin
2023-08-10 20:00 ` John Baldwin
2023-08-10 22:11 ` Greg Savin
2023-08-10 22:11 ` [PATCH v2 1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6 Greg Savin
2023-08-11 12:23 ` Andrew Burgess [this message]
2023-08-10 22:11 ` [PATCH v2 2/2] Propagate NT_RISCV_VECTOR from Linux kernel headers to binutils. The value is identical to pre-existing NT_RISCV_CSR but the note names different (NT_RISCV_CSR is "GDB" and NT_RISCV_VECTOR is "CORE") Greg Savin
2023-08-11 12:51 ` Andrew Burgess
2023-08-11 16:43 ` Palmer Dabbelt
2023-08-12 0:47 ` John Baldwin
2023-08-12 0:50 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg2xdaz6.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=greentime.hu@sifive.com \
--cc=greg.savin@sifive.com \
--cc=jhb@freebsd.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).