From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1D5F53858D20 for ; Fri, 11 Aug 2023 12:23:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D5F53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691756593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X95a7Sn0CvGMr8RMi0tuT6FCfgL+1vdY0J8/LK9i7Mo=; b=FRPv/FarKu9ONPf8Pe7d7ODRVqzhQfXwGdEXQf7NWKZ0on8viBT1yng/8KUnLbbuX29PKx i824g3eCFmB8wBUUt56CO+UOeXjHg46ceMjjXTtdmJe5w1gv5v9xJT5hRCb+MtWO2NqlHx 4wl7ca3Zl8g5hl5/W90hRQp2BnVqfxE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-50R5aKyuP-C--J-2NAZU_Q-1; Fri, 11 Aug 2023 08:23:12 -0400 X-MC-Unique: 50R5aKyuP-C--J-2NAZU_Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fe1dadb5d2so11812915e9.1 for ; Fri, 11 Aug 2023 05:23:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691756591; x=1692361391; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X95a7Sn0CvGMr8RMi0tuT6FCfgL+1vdY0J8/LK9i7Mo=; b=T+Y2Na23+HCdufVFy2Bqbee7kjFpeE6+bIemaTOe1nzFh+SSSPp5v9QRtaIUq+uh3T WBmym/tSa78kQkH3hLyMHduo8+UKXhwnTdOh4gDOILGdFhxAirv5azu8rouDO4LIxY1L /CBd9OEnaTVzC9mpJy153c2/8SCS2sA/ol2aBZI6UbbQ1N8INQ8O3wT7zv9QCueYNFa4 Y66n7QhG47m9ppQs5oB77aK2aRcIt1Fhopiy4/zTtktQZmnbPzKkd8nYLT1VyiesTN2y TWnzqKaGaaCumDZCYhflKDykVVplCsSyv3DFauFadPCN703RCgGmyrcqZjFNB1HadziX aa8g== X-Gm-Message-State: AOJu0YwlyqAMz0U1u/ClT8RXXd9TYiPcSlXV8MGeePbnlxm31687vvww 2vfSWGzuxkQtTBG2T2zpydjcgyxNXf/whApdB1TQ7ePMO9vPPfrEqnygHYIy/9O/t5N0TNdIV2U eMIXes2A+pOW6U2gjwnMV9A== X-Received: by 2002:a7b:c459:0:b0:3fe:45e7:1d6f with SMTP id l25-20020a7bc459000000b003fe45e71d6fmr1461565wmi.21.1691756591443; Fri, 11 Aug 2023 05:23:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpMUqkkbdztR0bCMN9zIQUjxciD4C1+TydYySKRxUw7wNa1sHPJyGB1Gcb32aICoPKPjSIfQ== X-Received: by 2002:a7b:c459:0:b0:3fe:45e7:1d6f with SMTP id l25-20020a7bc459000000b003fe45e71d6fmr1461550wmi.21.1691756591093; Fri, 11 Aug 2023 05:23:11 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c228800b003fbcf032c55sm7995337wmf.7.2023.08.11.05.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 05:23:10 -0700 (PDT) From: Andrew Burgess To: Greg Savin via Binutils , gdb-patches@sourceware.org, binutils@sourceware.org, palmer@dabbelt.com, greentime.hu@sifive.com, John Baldwin Cc: Greg Savin Subject: Re: [PATCH v2 1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6 In-Reply-To: <20230810221122.1155980-2-greg.savin@sifive.com> References: <20230810221122.1155980-1-greg.savin@sifive.com> <20230810221122.1155980-2-greg.savin@sifive.com> Date: Fri, 11 Aug 2023 13:23:09 +0100 Message-ID: <87zg2xdaz6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Greg Savin via Binutils writes: > --- > include/elf/common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/elf/common.h b/include/elf/common.h > index ffa6b60bd2b..e7eede23a07 100644 > --- a/include/elf/common.h > +++ b/include/elf/common.h > @@ -714,7 +714,7 @@ > #define NT_LARCH_LBT 0xa04 /* LoongArch Binary Translation registers */ > /* note name must be "CORE". */ > #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */ > - /* note name must be "LINUX". */ > + /* note name must be "GDB". */ I'm not a binutils maintainer, so can't approve this, but did originally add NT_RISCV_CSR. FWIW, this change LGTM. Thanks, Andrew > #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ > #define NT_FILE 0x46494c45 /* Description of mapped files. */ > > -- > 2.25.1