From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 90ADB3858CD1 for ; Mon, 31 Jul 2023 16:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90ADB3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-348f5193c12so14508595ab.2 for ; Mon, 31 Jul 2023 09:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690821527; x=1691426327; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uFsEQFEGTgzuCglKymDyw3j5rmdR93Ni9r0gvp+40Hc=; b=ERzsx7EY1bL1jtI5sGnWsZEP2BsA+S/W4+NPP1pYwRgIPSsdKBjkqeZXLgR2P0R6vo UsoXF3AarBgQZn3ET0CkAg3Mtw+HjyJmp5wsWBR8jqHIn7TFqiMNwoNv8xGdC4AMp+cu CeQenQIagK2gbUDs30/abQgAPZ1xeUi9tZPLCigt/6CrlSXw5vVsWVvCEkf5GRefrasw SfBprxQ+aHnaDmaL8/xKHdGTSvmvsFRGX5B/YT7cSwn3miK+GSQ+BRE5bXdjlZfWWKxe 19whvLo3wwxU6XppSfAbTRrf6ae8HDbxhDefyhqJknXy9Q1ilnh1T+P+YNAqj7EguPeT XVgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690821527; x=1691426327; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uFsEQFEGTgzuCglKymDyw3j5rmdR93Ni9r0gvp+40Hc=; b=gfpsX06J3R0edC2PCFj2B6JK/jq/XhjHDKOAY5YLB3rStK2Y6JFXHKucUyjCrigMl2 oz81P+/FmtJgb6IPwlpwF83NhkKFDNWtYwTEj3KZkOBk6g2B6OZW1GFDz0Ogyxe+JYlP VBCMRzGn1Al+vf2Nis/sPsljNcHyJXUGIKq+QUpuuFqo1yXCnxNly/s66RBlfEknHr5L OFDfucsRoRQukzQsnqzBLWKmwf0boncmMuKkQdE0henCQof42+b9oqckuAdR7qIgoS+3 TNGDq9r619XLXtGc3h6KOkZRlxzl3bfBCuHTpbdrKOdoegkWzYw7NYFIh72yrXxBnl2h tYIQ== X-Gm-Message-State: ABy/qLZDiXaGeBzaW/3KHe32EUkwx3rsTehpergBGhLoTJhq58siJXSM NhC6udzG3R/eN9SRc/X7fUBNDw== X-Google-Smtp-Source: APBJJlGERfUIwTFK7Zzd4kXiBoK7sni1SN2LvKz8RbSdaxcU8m79I9mARGymRca7DJ4bz9tBGZ5rAA== X-Received: by 2002:a05:6e02:13ea:b0:348:fe78:e9ed with SMTP id w10-20020a056e0213ea00b00348fe78e9edmr8273055ilj.7.1690821527679; Mon, 31 Jul 2023 09:38:47 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id cw11-20020a05663849cb00b0042af069eeefsm3026413jab.50.2023.07.31.09.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 09:38:47 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix bug in fixed-point handling References: <20230719152442.67508-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 31 Jul 2023 10:38:46 -0600 In-Reply-To: <20230719152442.67508-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 19 Jul 2023 09:24:42 -0600") Message-ID: <87zg3cf33d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> Alexandre Oliva found a bug in gdb's handling of fixed-point -- a Tom> certain Ada fixed-point type would be misintepreted. The bug was that Tom> the DW_AT_small looked like: Tom> <1><13cd>: Abbrev Number: 16 (DW_TAG_constant) Tom> <13ce> DW_AT_GNU_numerator: 1 Tom> <13cf> DW_AT_GNU_denominator: 0x8000000000000000 Tom> ... but gdb interpreted the denominator as a negative value. I'm checking this in. Tom