From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9AF233858439 for ; Tue, 16 May 2023 10:56:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AF233858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684234563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjxOI5r0oEyAUZrpe3WYFUG/tBglktuhFLORqhj1ONg=; b=Izz9ptuefljJYXCoE7kYLdlfQKZqWiULrGAYKgBaxkYfVXEgaFxVH746IUsUL+Rul8TmiF jTMtbpW1nRlljgjHj9mIldY2Pxy0enVRBVo38HEGhNdgAEZ3+0CkaWEVnIlK7Ji0bAB8GU 4vtnHG8dvuNOe/VVAxgdHuPmoXicpxE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-5600AqMxP2G_zPTM2M7IKw-1; Tue, 16 May 2023 06:56:02 -0400 X-MC-Unique: 5600AqMxP2G_zPTM2M7IKw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f4245ffbb4so56364965e9.3 for ; Tue, 16 May 2023 03:56:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684234561; x=1686826561; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fYCiVQeoftddVD1YXemjeMjU56mf8bhuXGtWO+grGII=; b=lKc6fyuxCdspseH8Ti61K29doAIWNX0T/4S5ycihyO/QRxf0/DJfuCSMkULThfbQId ISlFCZlx1rjcxNS1gWG3U7NvYf2UKXyuJ9/Jx2f9JMJGlXeS2/t69p+eOvsqPSpa6gWg XmUAf+VYBKXSqWtxR9g7gNSLobwbV8yvberDaWGjYRglCw2K/Mt/gKwoj31lZKjZiduZ YYhw+ctpQSDAp9owVyy6J56dG9+PhHxwN+fT9EbNgfw6IEUynoB1foTs4+8c5OYGcUOF 8gTlJc8mRtFfUY2GnNds5vYU0F30qcmAnf1GCEsRDIlGntK5ZIMnJ22FllP6yIRJDN4r /rPA== X-Gm-Message-State: AC+VfDzXdhTE+AlcCJ3kGTcKCtoDEjx15GoDkVEWTV0yB5qAEwyuuW1Z FkM2cuCFDwKCkhuocAn+EZSxsE4Kc0gWwoCPpOeDkv5Cb3GVdHoc5e6qtp2u55Xng4Ekci7WOC/ jRtyVqJTZW3eTieD0egRItQRZOxU0oA== X-Received: by 2002:a5d:4dc1:0:b0:307:97d9:d9a with SMTP id f1-20020a5d4dc1000000b0030797d90d9amr22317268wru.13.1684234561027; Tue, 16 May 2023 03:56:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4blA8A5yuz7rCE1Uu1QD0vrd+eD212SpVrMAzMtstA9FGXioHoNTWa+jQ77MWnRW0Wg+Bmuw== X-Received: by 2002:a5d:4dc1:0:b0:307:97d9:d9a with SMTP id f1-20020a5d4dc1000000b0030797d90d9amr22317260wru.13.1684234560723; Tue, 16 May 2023 03:56:00 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id m18-20020adffe52000000b002f9e04459desm2174533wrs.109.2023.05.16.03.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 03:56:00 -0700 (PDT) From: Andrew Burgess To: Paul Pluzhnikov , gdb-patches@sourceware.org Cc: Keith Seitz , Paul Pluzhnikov Subject: Re: [PATCH] Update comments for the gdb/24331 fix. In-Reply-To: <20230515151300.3188497-1-ppluzhnikov@google.com> References: <87a5y653qq.fsf@redhat.com> <20230515151300.3188497-1-ppluzhnikov@google.com> Date: Tue, 16 May 2023 11:55:59 +0100 Message-ID: <87zg64a6kg.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Paul Pluzhnikov writes: > On Mon, May 15, 2023 at 2:43=E2=80=AFAM Andrew Burgess wrote: >> >> It's fine to reference the bug, but could you expand this comment to say >> what's actually being tested, e.g. > > Sorry, I've already committed previous patch. > Ok to commit this one? LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Thanks, > > --- > gdb/testsuite/gdb.base/printcmds.exp | 5 ++++- > gdb/testsuite/gdb.python/py-format-string.exp | 2 -- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.bas= e/printcmds.exp > index f2be549f2a5..2506f745f20 100644 > --- a/gdb/testsuite/gdb.base/printcmds.exp > +++ b/gdb/testsuite/gdb.base/printcmds.exp > @@ -1077,7 +1077,10 @@ proc test_repeat_bytes {} { > } > } > =20 > -# Test for BZ#24331 > +# Test that 'set elements' correctly limits the number of characters > +# printed from a string when a string ends with repeated characters. > +# This is gdb/24331 > + > proc test_repeat_bytes_limit {} { > gdb_test "print -elem 3 -- \"AAAAA\"" "=3D \"AAA\"..." > gdb_test "print -char 3 -elem 10 -- \"AAAAA\"" "=3D \"AAA\"..." > diff --git a/gdb/testsuite/gdb.python/py-format-string.exp b/gdb/testsuit= e/gdb.python/py-format-string.exp > index 2a011ebd45a..55a37766bff 100644 > --- a/gdb/testsuite/gdb.python/py-format-string.exp > +++ b/gdb/testsuite/gdb.python/py-format-string.exp > @@ -745,8 +745,6 @@ proc test_max_string_one { setting unlimited } { > "${default_pointer_regexp} \"hel\"..." > check_format_string "a_binary_string" $opts \ > "${default_pointer_regexp} \"hel\"..." > - # This will print four characters instead of three, see > - # . > check_format_string "a_binary_string_array" $opts \ > "\"hel\"..." > check_format_string "a_big_string" $opts \ > --=20 > 2.40.1.606.ga4b1b128d6-goog