From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0CB253858D33 for ; Fri, 5 May 2023 17:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CB253858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683306290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s4ZHhfqsfGNF2gPNsKxhchosuHbjDOFiNzTE/J3L+Ic=; b=bLmMPRZoVikNUEMUiwCDRRJq9/YM2HmSg23qrg35mwNZ2/2vdpHb1aFSFEtsl2tDk/H6V2 V0XtqRGOd3QtbdFGhhLxnpbSBKoOhZG+e0qHaOObKN/uhzkqnZd8zNW8uSq0pyQGAm/gOb KZIWWHkO/cSiisNNuncBmqZqwh5xOjc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-wYoywJmQNL2czHnvTMKsdQ-1; Fri, 05 May 2023 13:04:49 -0400 X-MC-Unique: wYoywJmQNL2czHnvTMKsdQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3064d0b726fso740030f8f.0 for ; Fri, 05 May 2023 10:04:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683306288; x=1685898288; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s4ZHhfqsfGNF2gPNsKxhchosuHbjDOFiNzTE/J3L+Ic=; b=lcaowEv9RZPz2tDcbeZ5W02u7UX/vr7Rds4PUNW9zrAcm0cyk9F14MN6kvm0Algl4o ms8yCA88TPUE9JgWEzPu/sPqM1ttLdyKXOFRDOIs2h6uDsAD0uMlxSjZLSErk111C2+f 20E2Uzlobs/Mi0XLFzNKGRrqWTq/3dpf17MfOxVayrZ2Zzmt8CoT09PU+ajbsRuCb0Dt EBLRVE0uYC5nMRH2HM6skyBPF/Az6CkehL5aCB2fVIveeCXa5RtCWwBb3B6zVLmxjQ+S cZT8G3teBDUfNrY6mKBPOQ1NldO/nFN8yj4e7CtRWq30vSnirzIJFMCcqrgTbad06oS+ wZlg== X-Gm-Message-State: AC+VfDz+wcgd7BSgBJnSKxERa5jzKY8OZry+fbt1i5eVQczDWK7KymKh AN5dloHZyH92CwAsc0ctzOUDgX3f4oTVS4XUe+HytPx3kUSx4S6GT6cmdlGH9RlL9QcHgXYlwSB fBqtmqcrKtpNTrsJLNvL13Z92Rgh2Lg== X-Received: by 2002:a5d:5286:0:b0:2cf:ee9d:ce2f with SMTP id c6-20020a5d5286000000b002cfee9dce2fmr1940777wrv.19.1683306287910; Fri, 05 May 2023 10:04:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7c3Ytk6x1KBzn3lXqStitklR+VKj0GraH3FYLmN0GllKff0xGQ5xxOau31A4VeM0M8Pow09w== X-Received: by 2002:a5d:5286:0:b0:2cf:ee9d:ce2f with SMTP id c6-20020a5d5286000000b002cfee9dce2fmr1940768wrv.19.1683306287591; Fri, 05 May 2023 10:04:47 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id q10-20020adfdfca000000b003074d06e6b1sm2901754wrn.95.2023.05.05.10.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 10:04:47 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PUSHED] gdb/testsuite: compile gdb.linespec/cp-completion-aliases.exp as C++ In-Reply-To: <5df3f24f-019c-4d19-73c8-d7c6ff811546@suse.de> References: <4e545e3f3d600e62ed6522e0ed6ef609a6fe8354.1683024857.git.aburgess@redhat.com> <5df3f24f-019c-4d19-73c8-d7c6ff811546@suse.de> Date: Fri, 05 May 2023 18:04:45 +0100 Message-ID: <87zg6i7lqq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > On 5/2/23 12:54, Andrew Burgess via Gdb-patches wrote: >> Noticed in passing that the prepare_for_testing call in >> gdb.linespec/cp-completion-aliases.exp does not pass the 'c++' flag, >> despite this being a C++ test. >> >> I guess, as the source file has the '.cc' extension, all the compilers >> are doing the right thing anyway -- the source file uses templates, so >> is definitely being compiled as C++. >> >> I noticed this when I tried to set CXX_FOR_TARGET (but not >> CC_FOR_TARGET) and spotted that this script was still using the C >> compiler. >> >> Fixed in this commit by adding the 'c++' flag for prepare_for_testing. > > Hi, > > this is an instance of > https://sourceware.org/bugzilla/show_bug.cgi?id=30380 . > > I already had this fixed in a branch, but hadn't had time to submit. > > FWIW, it's the top commit of > https://github.com/vries/gdb/commits/testsuite/old-gcc . Sorry for duplicating this work. I ran into this case while working on some other patch and I didn't want to have to carry around such a trivial local patch. Hope this didn't cause you any serious problems. Thanks, Andrew