From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id C98C63858D32 for ; Fri, 7 Apr 2023 18:09:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C98C63858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 3787B10040610 for ; Fri, 7 Apr 2023 18:09:50 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id kqX0pPBxwNX2akqX0p2zN5; Fri, 07 Apr 2023 18:09:50 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=64305c6e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=XiM3UP_hv2688ePgN9gA:9 a=zgiPjhLxNE0A:10:nop_mobile_phish_fin_what DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MR2Y5nxbXiziru7hJWYqleMED1Cy4tUdY/r+OdCichI=; b=C0ZXx4hZh/ypTPK9+Ft6QqYbVY uSfCtOw55MPUhN2lwQ5USUbF544powAkaJMrwfuu7/HTgsryFHpAgWu55NPg5NRTQMUZpiDPyITqq 4iflZBXNLTHqQouUkdeoGiStM; Received: from 75-166-159-36.hlrn.qwest.net ([75.166.159.36]:43162 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pkqWz-003qEB-WB; Fri, 07 Apr 2023 12:09:50 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use std::string in substitute_path_component References: <20230404185212.1788207-1-tom@tromey.com> <2ea12788-551e-b043-163a-b1063ce53098@simark.ca> X-Attribution: Tom Date: Fri, 07 Apr 2023 12:09:47 -0600 In-Reply-To: <2ea12788-551e-b043-163a-b1063ce53098@simark.ca> (Simon Marchi's message of "Tue, 4 Apr 2023 21:17:51 -0400") Message-ID: <87zg7j5ztg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.159.36 X-Source-L: No X-Exim-ID: 1pkqWz-003qEB-WB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-159-36.hlrn.qwest.net (prentzel) [75.166.159.36]:43162 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> But a random thought I had while reading it: the sole user of Simon> substitute_path_component is auto_load_expand_dir_vars, which splits the Simon> path in components just after that. It would seem much simpler to do Simon> the $datadir / $debugdir replacement after the split, by iterating on Simon> the vector and checking each element. Anyway, not a big deal. Good idea, I sent a v2 that does this. Tom