From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1337B3858426 for ; Mon, 27 Feb 2023 14:15:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1337B3858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677507330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xnwRXTGwiXZASFPiDruijJ5dtTZ6MHu0T2vjfRpgZOg=; b=K91jN3x+qQllruiV2pVpePCXdN1NyvZzRmywe+nJYAGFtIdgfQgmCJzPGpMam0NZ3kwB2y QJ/WoMICfxsb81ElP1NPeN2cXq5bWjZIsegYKjGgW6G4IQ2hMIOPmPCIoN6kDcUX8+M8uP rZq+WHPWS0+pWriw1NDXIby3hVAFuRo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-224-ecoQwUFNOlCAAskfxhG1gg-1; Mon, 27 Feb 2023 09:15:29 -0500 X-MC-Unique: ecoQwUFNOlCAAskfxhG1gg-1 Received: by mail-wm1-f69.google.com with SMTP id r7-20020a05600c35c700b003eb3f2c4fb4so1711951wmq.6 for ; Mon, 27 Feb 2023 06:15:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677507327; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xnwRXTGwiXZASFPiDruijJ5dtTZ6MHu0T2vjfRpgZOg=; b=Zprm4diTNv+5mIOcqqY+CMdRIqXf9duIXMwCLmK3J7QqegzZhBjSLN7FfDejt3/xaj mX7IQ9I3I231y8UnTaNDTUgY44fTfvPzH601thbcaRVQw+JhBthbcgnmQdE2gJi5fWGN NOdrA/gqpf6xhkzAeN0KIp3yeqyuyGahcNDzyjILyzV0w1VblQpZqnVBijWNJN/4SWr+ HmzaNkkbWyRRHFnZQPQtoupi2N2AERe17hkWzAxhhZq+sjKBJ4ffT8NYWhPOMlPtUJx9 EeuMTpQe8hgdiptLTbn7LSXvttTJP+AtlMq0O5/mjQ9ytRq0hiNnPG076DyOErEPK1Tz /4SA== X-Gm-Message-State: AO0yUKWAR3sKtF80+HqqdagsEuRgm5ToIfU8ipZNpPxq323xb868u2jV dli3Ieu3gw6jGKjyPRPCB13AVJvtUEGsJcKvVitNYclVaaoNbihVStsaZryx0Ndsh60M9vAXeX2 yD0ltAlezqmVobAlVN3TUS6Fa0FQ= X-Received: by 2002:adf:f3cd:0:b0:2c7:1324:dba8 with SMTP id g13-20020adff3cd000000b002c71324dba8mr11393322wrp.49.1677507327778; Mon, 27 Feb 2023 06:15:27 -0800 (PST) X-Google-Smtp-Source: AK7set8NeTkU6IiVkAwGsSqqea78hQ7GxnPvuNXhdJ+x+7NWf+bFKk0kewq8dpskmKhmAhDHhle2OA== X-Received: by 2002:adf:f3cd:0:b0:2c7:1324:dba8 with SMTP id g13-20020adff3cd000000b002c71324dba8mr11393305wrp.49.1677507327430; Mon, 27 Feb 2023 06:15:27 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id j4-20020a5d6044000000b002c53f6c7599sm7256829wrt.29.2023.02.27.06.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 06:15:26 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH] gdb: don't treat empty enums as flag enums In-Reply-To: <87fsayn6ub.fsf@tromey.com> References: <92a46a82cbc43033fc03942674b80979cc91e572.1676901184.git.aburgess@redhat.com> <87fsayn6ub.fsf@tromey.com> Date: Mon, 27 Feb 2023 14:15:25 +0000 Message-ID: <87zg8zi48y.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> In C++ it is possible to use an empty enum as a strong typedef. For > Andrew> example, a user could write: > > Andrew> enum class my_type : unsigned char {}; > > Andrew> Now my_type can be used like 'unsigned char' except the compiler will > Andrew> not allow implicit conversion too and from the native 'unsigned char' > Andrew> type. > > ... > Andrew> I propose adding an extra check here; that is, an empty enum should > Andrew> never be a flag enum. > > Looks good to me, thank you. > > Reviewed-By: Tom Tromey Pushed. Thanks, Andrew