From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 2DEBA3858C60 for ; Thu, 16 Feb 2023 19:20:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DEBA3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12d.google.com with SMTP id h7so694690ila.7 for ; Thu, 16 Feb 2023 11:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=i9RIDYUFtCO8G1VgsrWDFXEjwUBG0DLxStI1weaAZGI=; b=d5dZnZ9weBHCcHQ//UCQsZQx3wHTEskoMk2B1m5wa/hN78HOzn4gIfQjK7ujWNnXfl fDcHNVQ9Czd4gvOJYGM4x2xno0Riv9aKUnYVHdFTl742ySLOdZjd58yjcLaD2sxEPd2S FDHYTak5W1yuWhyMWQf94gEFmHWXLHbPwixJDRcnGGlz8SY4+qsrfsRmdbFBo3/V4r05 nSmZzcHeBa6zJttKRKJSxJfqiXbPqK9UZ6eFAahTf8U3SXDWJ74uakiydNmseB1TR1LR XKVY769xwwnggdqRQxUi4JZJBhAi/ZDkIeDHuy9ApUrxPAkxbFZKKdLr34NcdKfbMG/N aeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i9RIDYUFtCO8G1VgsrWDFXEjwUBG0DLxStI1weaAZGI=; b=X+yWpUGml9VcNWKlV0BTRWOe7PN8JOiFX1YZc3m+caJ12G+zQFMvxXmFV0sA9yEXoZ hxClpucdA28fP/tYt3rV49+vx4kfLuPg2N3m+bqK2MCEZqPxQ00rIcBNyo4g6aG4mz/C 6caRQxuY2iAAVvLKA9p/uXCKlhw9qkBExLw4VMkP03H6yXmx+VpV26qvXYAOPbevXuh+ ddjdsKetN8DdlTWJt8dgga/PwLmcGx86B22iOAIcbwjImNirGneMc7alaws8+W9ieg0U oqWMofYANE49UGVJDuUAv2oobVSNSxcDLx3JMuY9vJIMK8W6IqphY6udooC2v3mXLAjO m00w== X-Gm-Message-State: AO0yUKUgNcg8SB4AuNmZizV3ufIrO+5TG2seex+MwVj93qkO0kB/su6G Vzp162EXPgIX2hMAd3Js4KMYww== X-Google-Smtp-Source: AK7set+Gr6qL9mW5UszUfnwgF2G87Lfm15YDll270v6uI3zzsuAOtSioDqgS0mxFOKCskuQdHoiEVQ== X-Received: by 2002:a05:6e02:216b:b0:315:59e8:ad2e with SMTP id s11-20020a056e02216b00b0031559e8ad2emr6798433ilv.20.1676575227437; Thu, 16 Feb 2023 11:20:27 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id i15-20020a056e02152f00b0031537da6ba3sm638297ilu.87.2023.02.16.11.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 11:20:26 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Andrew Burgess , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Do not record a rejected target description References: <20230112193356.1133696-1-tromey@adacore.com> <87bklwmenh.fsf@redhat.com> <875yc4tawn.fsf@tromey.com> <875yc3m6in.fsf@redhat.com> <871qmqsyvu.fsf@tromey.com> X-Attribution: Tom Date: Thu, 16 Feb 2023 12:20:25 -0700 In-Reply-To: (Simon Marchi's message of "Wed, 15 Feb 2023 16:19:08 -0500") Message-ID: <87zg9do1s6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> I see: Simon> maint print c-tdesc^M Simon> There is no target description to print.^M Simon> (gdb) FAIL: gdb.xml/maint_print_struct.exp: printing tdesc with a structure and a bitfield Here's a patch that avoids this problem. Let me know what you think. Tom commit a12897d22ccc1d927960fa411b99723d76620af0 Author: Tom Tromey Date: Thu Feb 16 12:17:50 2023 -0700 Fix regression in maint_print_struct.exp An earlier patch of mine caused a regression in maint_print_struct.exp. This patch fixes it by modifying the test so that it does not rely on the erroneous target description being available. diff --git a/gdb/testsuite/gdb.xml/maint_print_struct.exp b/gdb/testsuite/gdb.xml/maint_print_struct.exp index 6f411895501..5b7c1489d3e 100644 --- a/gdb/testsuite/gdb.xml/maint_print_struct.exp +++ b/gdb/testsuite/gdb.xml/maint_print_struct.exp @@ -21,12 +21,7 @@ require allow_xml_test gdb_start -# Required registers are not present so it is expected a warning. -# -gdb_test "set tdesc filename $srcdir/$subdir/maint_print_struct.xml" " -warning:.*" "setting a new tdesc having only a structure" - -gdb_test "maint print c-tdesc" " +gdb_test "maint print c-tdesc $srcdir/$subdir/maint_print_struct.xml" " .*tdesc_create_reg \\(feature, \"bad_reg1\", \[0-9\]+, 1, NULL, 128, \"two_fielded\"\\);\r .*tdesc_create_reg \\(feature, \"bad_reg2\", \[0-9\]+, 1, NULL, 64, \"bitfield\"\\);\r .*" "printing tdesc with a structure and a bitfield"