From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix comparator bug in cooked index
Date: Mon, 30 Jan 2023 07:30:02 -0700 [thread overview]
Message-ID: <87zga0nlhx.fsf@tromey.com> (raw)
In-Reply-To: <25a578ac-5036-832a-3577-8eb27996157f@simark.ca> (Simon Marchi's message of "Fri, 27 Jan 2023 23:20:10 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + /* Comparison modes for the 'compare' function. See the function
>> + for a description. */
>> + enum comparison_mode
Simon> Just a nit, but I like to use enum class. For the simple reason that
Simon> users do "comparison_mode::SORT" instead of just "SORT", and I find that
Simon> this little bit of context helps when reading.
I normally do too, but because it's in a class, this would lead to
outside users having to write cooked_index_entry::comparison_mode::SORT
which seemed excessively wordy.
Tom
next prev parent reply other threads:[~2023-01-30 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 19:56 Tom Tromey
2023-01-28 4:20 ` Simon Marchi
2023-01-30 14:30 ` Tom Tromey [this message]
2023-01-30 10:33 ` Andrew Burgess
2023-01-30 15:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zga0nlhx.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).